gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 31391: (QA follow-up) Remove unused variables in ModReserve recall conversion 

$due_interval and $due_date (and $recall itself) returned by
Koha::Recalls->add_recall were captured but never used in either
branch of the new rank => "recall" handling. Drop the unused
assignment - no behaviour change.

Test plan:
1) prove t/db_dependent/Holds.t t/db_dependent/Reserves.t - all pass

Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
This commit is contained in:
Martin Renvoize 2026-09-15 11:16:46 +01:00 committed by Pedro Amorim
parent 0b7d3b856a
commit 4ff58e553b
No known key found for this signature in database
GPG Key ID: 06B75BA7F3894D55
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
C4/Reserves.pm
View File

@ -1253,7 +1253,7 @@ sub ModReserve {
my $patron = Koha::Patrons->find($borrowernumber);
if ( $hold->item_level_hold ) {
if ( $hold->item->can_be_recalled( { patron => $patron, hold_convert => 1 } ) ) {
my ( $recall, $due_interval, $due_date ) = Koha::Recalls->add_recall(
Koha::Recalls->add_recall(
{
patron => $patron,
biblio => $biblio,
@ -1267,7 +1267,7 @@ sub ModReserve {
}
} else {
if ( $biblio->can_be_recalled( { patron => $patron, hold_convert => 1 } ) ) {
my ( $recall, $due_interval, $due_date ) = Koha::Recalls->add_recall(
Koha::Recalls->add_recall(
{
patron => $patron,
biblio => $biblio,