From 4f9cf0d8c26abc7bbf8359b078de67fd3af08233 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Mon, 17 Mar 2025 10:26:21 +0000 Subject: [PATCH] Bug 39354: Remove unintended Bootstrap 5 change to scroll-behavior This patch updates the "variables" SCSS file in the OPAC and staff interface in order to disable the "smooth scroll" behavior introduced in Bootstrap 5. This was an unexpected and unintentional change. The patch also corrects another unexpected side-effect of the BS5 upgrade: A change to the "cursor" property of elements with a ".placeholder" class. This class is used by the multiple-select jQuery plugin found in some system preference controls. To test, apply the patch and rebuild the staff and OPAC CSS. - Clear your browser cache if necessary. - In the staff interface, go to Administration -> System preferences -> Circulation, and click "Patron restrictions" in the left-hand sidebar. The page should jump immediately to that section without any scrolling effect. - Go to the "Article requests" section of that page. Hover your cursor over a dropdown which doesn't have any option selected. Your cursor should not change to a "waiting" cursor. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer (cherry picked from commit 09c79110a11e5d336734357328c858b3245c271b) Signed-off-by: Fridolin Somers --- koha-tmpl/intranet-tmpl/prog/css/src/_variables.scss | 2 +- koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 5 +++++ koha-tmpl/opac-tmpl/bootstrap/css/src/_variables.scss | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_variables.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_variables.scss index e583472f48..1416c7f0be 100644 --- a/koha-tmpl/intranet-tmpl/prog/css/src/_variables.scss +++ b/koha-tmpl/intranet-tmpl/prog/css/src/_variables.scss @@ -376,7 +376,7 @@ $enable-shadows: false; $enable-gradients: false; $enable-transitions: true; $enable-reduced-motion: true; -$enable-smooth-scroll: true; +$enable-smooth-scroll: false; $enable-grid-classes: true; $enable-container-classes: true; $enable-cssgrid: false; diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss index 3671795c2f..c427f29e40 100644 --- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss +++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss @@ -93,6 +93,11 @@ $enable-dark-mode: false; white-space: nowrap; } +.placeholder { + /* Override Bootstrap style which conflicts with multiple-select */ + cursor: default; +} + .dropup .dropdown-menu[data-bs-popper] { margin-bottom: 0; } diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/_variables.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/_variables.scss index 5ed6dc7ccd..a13d77991c 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/css/src/_variables.scss +++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/_variables.scss @@ -382,7 +382,7 @@ $enable-shadows: false; $enable-gradients: false; $enable-transitions: true; $enable-reduced-motion: true; -$enable-smooth-scroll: true; +$enable-smooth-scroll: false; $enable-grid-classes: true; $enable-container-classes: true; $enable-cssgrid: false;