gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 16587 opac-sendshelf.pl is vulnerable to XSS 

To test
1/ Hit a url like
http://localhost:8080/cgi-bin/koha/opac-sendshelf.pl?email=%3Cscript%3Ealert(%27XSS%27)%3C%2Fscript%3Ezz%40zz&comment=tes&shelfid=4
2/ Notice you get a js alert
3/ Apply patch
4/ Notice the js is now escaped

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
This commit is contained in:
Chris Cormack 2016-05-25 14:06:28 +00:00 committed by Brendan Gallagher
parent 05a014b766
commit 4e817ee04c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt
View File

@ -13,7 +13,7 @@
[% IF ( SENT ) %]
<h1>Message sent</h1>
<div class="alert alert-success">
<p>The list was sent to: [% email %]</p>
<p>The list was sent to: [% email | html %]</p>
</div>
<p><a class="focus close" href="/cgi-bin/koha/opac-shelves.pl?op=view&amp;shelfnumber=[% shelfid %]">Back to lists</a></p>
[% END %]