gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 24488: (QA follow-up) Go to next loop as early as possible 

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Josef Moravec 2020-11-19 06:27:49 +00:00 committed by Jonathan Druart
parent 97a6cb4b90
commit 4e296e78be
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
circ/pendingreserves.pl
View File

@ -252,6 +252,11 @@ foreach my $bibnum ( @biblionumbers ){
my $hold_info;
my $items = $all_items->{$bibnum};
my $items_count = defined $items ? scalar @$items : 0;
my $pull_count = $items_count <= $patrons_count->{$bibnum} ? $items_count : $patrons_count->{$bibnum};
if ( $pull_count == 0 ) {
next;
}
# get available item types for each biblio
my @res_itemtypes;
@ -286,16 +291,12 @@ foreach my $bibnum ( @biblionumbers ){
$hold_info->{holdingbranches} = [ uniq map { defined $_->holdingbranch ? $_->holdingbranch : () } @$items ];
# items available
my $items_count = scalar @$items;
$hold_info->{items_count} = $items_count;
# patrons with holds
$hold_info->{patrons_count} = $patrons_count->{$bibnum};
my $pull_count = $items_count <= $patrons_count->{$bibnum} ? $items_count : $patrons_count->{$bibnum};
if ( $pull_count == 0 ) {
next;
}
# number of items to pull
$hold_info->{pull_count} = $pull_count;
# get other relevant information