gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 43088: Reuse _current_directory() instead of duplicating pwd() calls 

_change_directory(), _list_files() and _is_connected() each called
$self->{connection}->pwd directly for their log payloads/connectivity
check, duplicating exactly what _current_directory() now provides as a
proper, documented internal accessor. Route them through it instead -
no behaviour change, just removing the duplication now that the
wrapper exists.

Test plan:
1. prove -r t/db_dependent/Koha/File/
   => All tests successful (32 tests), including the existing
      current_directory() and list_files()/change_directory() coverage.
2. koha-qa.pl -v 2 --more-tests
   => [PASS], no critic/pod warnings.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
This commit is contained in:
Martin Renvoize 2026-07-16 15:18:50 +01:00 committed by Pedro Amorim
parent 7a750c7e83
commit 4db4d8be55
No known key found for this signature in database
GPG Key ID: 06B75BA7F3894D55
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Koha/File/Transport/FTP.pm
View File

@ -165,7 +165,7 @@ sub _change_directory {
type => 'success',
payload => {
directory => $remote_directory,
pwd => $self->{connection}->pwd
pwd => $self->_current_directory
}
}
);
@ -267,7 +267,7 @@ sub _list_files {
type => 'success',
payload => {
count => scalar @file_list,
pwd => $self->{connection}->pwd
pwd => $self->_current_directory
}
}
);
@ -382,7 +382,7 @@ Internal method to check if transport is currently connected.
sub _is_connected {
my ($self) = @_;
return $self->{connection} && $self->{connection}->pwd();
return $self->{connection} && $self->_current_directory();
}
=head3 _abort_operation