gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 6298 : Hide avatars when ShowReviewer is off 

As suggested by Nicole, when a library hides the names of the
reviewers, they probably don't want to show their faces.

The OPAC detail page was already hiding these avatars but this
change also prevents Koha from looking for these avatars (which
could incur DNS queries) if they're not going to be displayed.

Signed-off-by: Francois Marier <francois@debian.org>
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
This commit is contained in:
Francois Marier 2011-05-06 10:00:51 -04:00 committed by Chris Cormack
parent f44b674ed5
commit 4d90c13eea
2 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
opac/opac-detail.pl
View File

@ -295,11 +295,10 @@ $template->param(
ocoins => GetCOinSBiblio($biblionumber),
);
my $libravatar_available = 0;
my $libravatar_enabled = 0;
eval 'use Libravatar::URL';
if (! $@) {
$libravatar_available = 1;
if (!$@ and C4::Context->preference('ShowReviewer')) {
$libravatar_enabled = 1;
}
my $reviews = getreviews( $biblionumber, 1 );
@ -310,7 +309,7 @@ foreach ( @$reviews ) {
$_->{title} = $borrowerData->{'title'};
$_->{surname} = $borrowerData->{'surname'};
$_->{firstname} = $borrowerData->{'firstname'};
if ($libravatar_available and $borrowerData->{'email'}) {
if ($libravatar_enabled and $borrowerData->{'email'}) {
$_->{avatarurl} = libravatar_url(email => $borrowerData->{'email'}, https => $ENV{HTTPS});
}
$_->{userid} = $borrowerData->{'userid'};

9
opac/opac-showreviews.pl
View File

@ -65,11 +65,10 @@ if($format eq "rss"){
);
}
my $libravatar_available = 0;
my $libravatar_enabled = 0;
eval 'use Libravatar::URL';
if (! $@) {
$libravatar_available = 1;
if (!$@ and C4::Context->preference('ShowReviewer')) {
$libravatar_enabled = 1;
}
my $reviews = getallreviews(1,$offset,$results_per_page);
@ -99,7 +98,7 @@ for my $result (@$reviews){
$result->{timestamp} = $bib->{'timestamp'};
$result->{firstname} = $borr->{'firstname'};
$result->{surname} = $borr->{'surname'};
if ($libravatar_available and $borr->{'email'}) {
if ($libravatar_enabled and $borr->{'email'}) {
$result->{avatarurl} = libravatar_url(email => $borr->{'email'}, size => 40, https => $ENV{HTTPS});
}