gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 25623: Make sure oauth.t rolls back the db 

This patch adds a missing transaction wrapping one of the subtests. This
is probably an oversight when refactoring this file.

To test:
1. Open the patron categories page
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/oauth.t
=> SUCCESS: Tests pass
3. Reload the patron categories page
=> FAIL: There's random data in there
4. Apply this patch and repeat 2
5. Reload the patron categories page
=> SUCCESS: The random data from the previous tests is still there, but
no new random data
=> SUCCESS: Tests still pass
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit f898cef4f4)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 0734017ab6)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
This commit is contained in:
Tomas Cohen Arazi 2020-05-29 14:41:25 -03:00 committed by Aleisha Amohia
parent 083ce15dee
commit 4c536ffbce
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
t/db_dependent/api/v1/oauth.t
View File

@ -84,6 +84,8 @@ subtest 'Net::OAuth2::AuthorizationServer missing tests' => sub {
plan tests => 10;
$schema->storage->txn_begin;
my $load_conditional = Test::MockModule->new('Module::Load::Conditional');
# Enable the client credentials grant syspref
@ -115,6 +117,7 @@ subtest 'Net::OAuth2::AuthorizationServer missing tests' => sub {
->status_is(400)
->json_is( { error => 'Unimplemented grant type' } );
$schema->storage->txn_rollback;
};
sub run_oauth_tests {