gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 16942 - Confirm hold results in ugly error 

Confirming a hold to set it to waiting will result in an DBIC error in
master.

Test Plan:
1) Attempt to check in an item on hold and confirm the hold
2) Note the error
3) Apply this patch
4) Repeat step 1
5) Note there is no error!

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>

https://bugs.koha-community.org/show_bug.cgi?id=14942

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Kyle M Hall 2016-07-19 16:57:25 +00:00
parent 53631f9ffd
commit 49af4e0ddf
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
C4/Letters.pm
View File

@ -1485,7 +1485,15 @@ sub _get_tt_params {
my $id = ref $ref eq 'HASH' ? $tables->{$table}->{$pk} : $tables->{$table};
my $object;
if ( $fk ) { # Using a foreign key for lookup
$object = $module->search( { $fk => $id } )->next();
if ( ref( $fk ) eq 'ARRAY' ) { # Foreign key is multi-column
my $search;
foreach my $key ( @$fk ) {
$search->{$key} = $id->{$key};
}
$object = $module->search( $search )->next();
} else { # Foreign key is single column
$object = $module->search( { $fk => $id } )->next();
}
} else { # using the table's primary key for lookup
$object = $module->find($id);
}