gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

followup to previous patch - don't use TMPL_IF EXPR 

Because of the way that HTML::Template::Pro evaluates
expressions, any variable referred to in a TMPL_IF EXPR
must be be present when the template is parsed, otherwise
you get Apache error log warnings like this:

non-initialized variable new_subfield

For a simple flag check, TMPL_IF NAME="new_subfield" is sufficient.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
This commit is contained in:
Galen Charlton 2009-05-22 07:41:22 -05:00 committed by Henri-Damien LAURENT
parent 868d21d905
commit 493cb8c651
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tmpl
View File

@ -89,7 +89,7 @@
<!-- TMPL_LOOP NAME="loop" -->
<div id="sub<!-- TMPL_VAR NAME="urisubfieldcode" -->field">
<fieldset class="rows"><legend><!-- TMPL_IF EXPR="new_subfield eq 1" -->Add new subfield<!-- TMPL_ELSE -->Basic constraints<!-- /TMPL_IF --></legend>
<fieldset class="rows"><legend><!-- TMPL_IF "new_subfield" -->Add new subfield<!-- TMPL_ELSE -->Basic constraints<!-- /TMPL_IF --></legend>
<ol>
<!-- TMPL_IF EXPR="subfieldcode eq 0 || subfieldcode" -->
<li><span class="label">Subfield code:</span> <!-- TMPL_VAR NAME="subfieldcode" --> <input type="hidden" name="tagsubfield" value="<!-- TMPL_VAR NAME="subfieldcode" -->" /></li>