gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 22946: Markup error in OPAC search results around selection links 

This patch makes minor corrections to the template for OPAC search
results. These corrections fix errors returned by the HTML validator.

To reproduce the problem, make sure holds and/or tags are enabled in the
OPAC. Perform a search in the OPAC which will return multiple results.
Run the page through the W3C validation service:
https://validator.w3.org. Either by pasting in the URL for the search
results (if web accessible) or by viewing source, copying, and pasting
into "Validate by Direct Input."

This patch addresses one specific error:

 - "Element div not allowed as child of element span in this context."

To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the search results view.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Owen Leonard 2019-05-21 12:39:09 +00:00 committed by Martin Renvoize
parent d018953ca1
commit 48259267f6
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
View File

@ -189,15 +189,15 @@
<span id="tagsel_span">
<input id="tagsel_tag" class="disabled" type="submit" value="Tag"/>
</span>
<div id="tagsel_form" style="display:none">
<span id="tagsel_form" style="display:none">
<label for="tagsel_new">New tag:</label>
<input type="text" name="tagsel_new" id="tagsel_new" maxlength="100" />
<input id="tagsel_button" name="tagsel_button" class="tagsel_button btn btn-small" title="Add" type="submit" value="Add" />
<a href="#" id="tagsel_cancel">(done)</a>
</div>
<div id="tagsel_status" class="tagsel_tatus" style="display:none;">
</span>
<span id="tagsel_status" class="tagsel_tatus" style="display:none;">
Tag status here.
</div>
</span>
[% END %]
</span> <!-- / .links -->
</div> <!-- / #selections-toolbar -->