gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 12045 - Transfer impossible if barcode includes spaces 

have changed the code which strips the white space to only remove the leading and trailing white space instead

To Test-
1- go to circulation -> transfer
2- attempt to tranfer an item where the barcode has a space in the middle of it
3- it should fail
4- apply patch
5- try again
6- it should work

NOTE: I purposefully added: die "($barcode)";
      Before, all spaces were removed.
          '    white space    ' became '(whitespace)'
      After, only external spaces were remove
          '    white space    ' became '(white space)'

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
This commit is contained in:
Chloe 2016-01-21 23:47:42 +00:00 committed by Brendan A Gallagher
parent a60943bc1b
commit 47caf69a46
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
circ/branchtransfers.pl
View File

@ -108,8 +108,8 @@ elsif ( $request eq 'KillReserved' ) {
my @trsfitemloop;
my $transfered;
my $barcode = $query->param('barcode');
# strip whitespace
defined $barcode and $barcode =~ s/\s*//g; # FIXME: barcodeInputFilter
# remove leading/trailing whitespace
defined $barcode and $barcode =~ s/^\s*|\s*$//g; # FIXME: barcodeInputFilter
# warn "barcode : $barcode";
if ($barcode) {