Bug 20942: Add route to get patron's account balance

This patch implements the /patrons/{patron_id}/account endpoint. It can
be used to get the patron's balance information, including outstanding
lines.

To test:
- Apply this patchset
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons_accounts.t
=> SUCCESS: tests pass!
- Make your favourite REST testing tool (RESTer on Firefox?) do:
  GET /api/v1/patrons/{patron_id}/account
to a valid patron_id. Play with Koha's UI to add credits/payments and
notice the endpoint returns the right info following the voted RFC. [1]
- Sign off :-D

[1] https://wiki.koha-community.org/wiki/Patrons_account_lines_endpoint_RFC

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit d079c80b05)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Tomas Cohen Arazi 2018-06-13 14:02:44 -03:00 committed by Martin Renvoize
parent 2dd7b408b3
commit 477cee1ae9
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
1 changed files with 157 additions and 0 deletions

View File

@ -0,0 +1,157 @@
package Koha::REST::V1::Patrons::Account;
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it under the
# terms of the GNU General Public License as published by the Free Software
# Foundation; either version 3 of the License, or (at your option) any later
# version.
#
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along
# with Koha; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
use Modern::Perl;
use Mojo::Base 'Mojolicious::Controller';
use Try::Tiny;
=head1 NAME
Koha::REST::V1::Patrons::Account
=head1 API
=head2 Methods
=head3 get
Controller function that handles retrieving a patron's account balance
=cut
sub get {
my $c = shift->openapi->valid_input or return;
my $patron_id = $c->validation->param('patron_id');
my $patron = Koha::Patrons->find($patron_id);
unless ($patron) {
return $c->render( status => 404, openapi => { error => "Patron not found." } );
}
my $balance;
$balance->{balance} = $patron->account->balance;
my @outstanding_lines = Koha::Account::Lines->search(
{ borrowernumber => $patron->borrowernumber,
amountoutstanding => { '!=' => 0 }
}
);
foreach my $line ( @outstanding_lines ) {
push @{ $balance->{outstanding_lines} }, _to_api($line->TO_JSON)
}
return $c->render( status => 200, openapi => $balance );
}
=head3 _to_api
Helper function that maps unblessed Koha::Account::Line objects
into REST API attribute names.
=cut
sub _to_api {
my $account_line = shift;
# Rename attributes
foreach my $column ( keys %{ $Koha::REST::V1::Patrons::Account::to_api_mapping } ) {
my $mapped_column = $Koha::REST::V1::Patrons::Account::to_api_mapping->{$column};
if ( exists $account_line->{ $column }
&& defined $mapped_column )
{
# key != undef
$account_line->{ $mapped_column } = delete $account_line->{ $column };
}
elsif ( exists $account_line->{ $column }
&& !defined $mapped_column )
{
# key == undef
delete $account_line->{ $column };
}
}
return $account_line;
}
=head3 _to_model
Helper function that maps REST API objects into Koha::Account::Line
attribute names.
=cut
sub _to_model {
my $account_line = shift;
foreach my $attribute ( keys %{ $Koha::REST::V1::Patrons::Account::to_model_mapping } ) {
my $mapped_attribute = $Koha::REST::V1::Patrons::Account::to_model_mapping->{$attribute};
if ( exists $account_line->{ $attribute }
&& defined $mapped_attribute )
{
# key => !undef
$account_line->{ $mapped_attribute } = delete $account_line->{ $attribute };
}
elsif ( exists $account_line->{ $attribute }
&& !defined $mapped_attribute )
{
# key => undef / to be deleted
delete $account_line->{ $attribute };
}
}
return $account_line;
}
=head2 Global variables
=head3 $to_api_mapping
=cut
our $to_api_mapping = {
accountlines_id => 'account_line_id',
accountno => undef, # removed
accounttype => 'account_type',
amountoutstanding => 'amount_outstanding',
borrowernumber => 'patron_id',
dispute => undef,
issue_id => 'checkout_id',
itemnumber => 'item_id',
manager_id => 'staff_id',
note => 'internal_note',
};
=head3 $to_model_mapping
=cut
our $to_model_mapping = {
account_line_id => 'accountlines_id',
account_type => 'accounttype',
amount_outstanding => 'amountoutstanding',
checkout_id => 'issue_id',
internal_note => 'note',
item_id => 'itemnumber',
patron_id => 'borrowernumber',
staff_id => 'manager_id'
};
1;