Bug 17824: Remove C4::Members::GetBorrowersWhoHaveNeverBorrowed
This subroutine is no longer in used and can be removed.
Test plan:
git grep GetBorrowersWhoHaveNeverBorrowed
must not return any results
NOTE: grep -i getborrowerswhohave `find . -type f`
works well enough to find the cleanborrowers.pl too.
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
parent
e429db4746
commit
42bef19fe9
|
|
@ -73,7 +73,6 @@ BEGIN {
|
|||
&GetBorNotifyAcctRecord
|
||||
|
||||
&GetBorrowersToExpunge
|
||||
&GetBorrowersWhoHaveNeverBorrowed
|
||||
&GetBorrowersWithIssuesHistoryOlderThan
|
||||
|
||||
&IssueSlip
|
||||
|
|
@ -1156,53 +1155,6 @@ sub GetBorrowersToExpunge {
|
|||
return \@results;
|
||||
}
|
||||
|
||||
=head2 GetBorrowersWhoHaveNeverBorrowed
|
||||
|
||||
$results = &GetBorrowersWhoHaveNeverBorrowed
|
||||
|
||||
This function get all borrowers who have never borrowed.
|
||||
|
||||
I<$result> is a ref to an array which all elements are a hasref.
|
||||
|
||||
=cut
|
||||
|
||||
sub GetBorrowersWhoHaveNeverBorrowed {
|
||||
my $filterbranch = shift ||
|
||||
((C4::Context->preference('IndependentBranches')
|
||||
&& C4::Context->userenv
|
||||
&& !C4::Context->IsSuperLibrarian()
|
||||
&& C4::Context->userenv->{branch})
|
||||
? C4::Context->userenv->{branch}
|
||||
: "");
|
||||
my $dbh = C4::Context->dbh;
|
||||
my $query = "
|
||||
SELECT borrowers.borrowernumber,max(timestamp) as latestissue
|
||||
FROM borrowers
|
||||
LEFT JOIN issues ON borrowers.borrowernumber = issues.borrowernumber
|
||||
WHERE issues.borrowernumber IS NULL
|
||||
";
|
||||
my @query_params;
|
||||
if ($filterbranch && $filterbranch ne ""){
|
||||
$query.=" AND borrowers.branchcode= ?";
|
||||
push @query_params,$filterbranch;
|
||||
}
|
||||
warn $query if $debug;
|
||||
|
||||
my $sth = $dbh->prepare($query);
|
||||
if (scalar(@query_params)>0){
|
||||
$sth->execute(@query_params);
|
||||
}
|
||||
else {
|
||||
$sth->execute;
|
||||
}
|
||||
|
||||
my @results;
|
||||
while ( my $data = $sth->fetchrow_hashref ) {
|
||||
push @results, $data;
|
||||
}
|
||||
return \@results;
|
||||
}
|
||||
|
||||
=head2 GetBorrowersWithIssuesHistoryOlderThan
|
||||
|
||||
$results = &GetBorrowersWithIssuesHistoryOlderThan($date)
|
||||
|
|
|
|||
|
|
@ -36,7 +36,7 @@ use Modern::Perl;
|
|||
use CGI qw ( -utf8 );
|
||||
use C4::Auth;
|
||||
use C4::Output;
|
||||
use C4::Members; # GetBorrowersWhoHavexxxBorrowed.
|
||||
use C4::Members;
|
||||
use C4::Circulation; # AnonymiseIssueHistory.
|
||||
use Koha::DateUtils qw( dt_from_string output_pref );
|
||||
use Koha::Patron::Categories;
|
||||
|
|
|
|||
Loading…
Reference in New Issue