gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 29809: (follow-up) Update tests and rename variable 

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Nick Clemens 2022-01-18 11:55:59 +00:00 committed by Fridolin Somers
parent 09fad02ae8
commit 41f2607563
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
t/db_dependent/StockRotationItems.t
View File

@ -267,7 +267,7 @@ subtest "Tests for needs_advancing." => sub {
)->store;
is($dbitem->needs_advancing, 1, "Ready to be advanced.");
$dbtransfer->delete;
warning_is {$dbitem->needs_advancing} "We have no historical branch transfer for itemnumber " . $dbitem->item->itemnumber . "; This should not have happened!", "Missing transfer is warned.";
warning_is {$dbitem->needs_advancing} "We have no historical branch transfer for item " . $dbitem->item->itemnumber . "; This should not have happened!", "Missing transfer is warned.";
$schema->storage->txn_rollback;
};
@ -469,13 +469,13 @@ subtest "Tests for advance." => sub {
class => 'Koha::Checkouts',
value => {
branchcode => $srstage_1->branchcode_id,
itemnumber => $sritem_1->itemnumber->itemnumber,
itemnumber => $sritem_1->item->itemnumber,
returndate => undef
}
});
$sritem_1->itemnumber->holdingbranch($srstage_1->branchcode_id)->store;
$sritem_1->item->holdingbranch($srstage_1->branchcode_id)->store;
ok($sritem_1->advance, "Advancement done.");
$transfer_request = $sritem_1->itemnumber->get_transfer;
$transfer_request = $sritem_1->item->get_transfer;
is($transfer_request->frombranch, $srstage_1->branchcode_id, "Origin correct.");
is($transfer_request->tobranch, $srstage_1->branchcode_id, "Target correct.");
is($transfer_request->datesent, undef, "Transfer waiting to initiate until return.");
@ -484,7 +484,7 @@ subtest "Tests for advance." => sub {
$sritem_1->advance; #advance back to second stage
# Set arrived
$transfer_request->datearrived(dt_from_string())->store;
$sritem_1->itemnumber->holdingbranch($srstage_2->branchcode_id)->store;
$sritem_1->item->holdingbranch($srstage_2->branchcode_id)->store;
$srstage_1->rota->cyclical(0)->store; # Set Rota to non-cyclical.

2
tools/stockrotation.pl
View File

@ -252,7 +252,7 @@ if (!defined $op) {
# Get all items on this rota, for each prefetch their
# stage and biblio objects
my $items = Koha::StockRotationItems->search(
my $sritems = Koha::StockRotationItems->search(
{ 'stage.rota_id' => $params{rota_id} },
{
prefetch => {