gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 24879: (follow-up) Fix test suite 

Running cataloguing pluings (in cataloguing/value_builder) now requires
authentification.

This patch adds in failing unit tests a mock of C4::Auth::check_cookie_auth

Test with:
prove t/db_dependent/FrameworkPlugin.t t/db_dependent/Koha/UI/Form/Builder/Biblio.t t/db_dependent/Koha/UI/Form/Builder/Item.t t/db_dependent/Serials.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Fridolin Somers 2024-03-27 10:20:03 +01:00 committed by Tomas Cohen Arazi
parent 609b4c6225
commit 4079bdfbe8
No known key found for this signature in database
GPG Key ID: 0A272EA1B2F3C15F
3 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
t/db_dependent/FrameworkPlugin.t
View File

@ -144,6 +144,7 @@ sub test05 {
my $mOutput = Test::MockModule->new('C4::Output');
$mContext->mock( 'userenv', \&mock_userenv );
$mAuth->mock( 'checkauth', sub { return ( 1, undef, 1, all_perms() ); } );
$mAuth->mock( 'check_cookie_auth', sub { return ('ok') } );
$mOutput->mock('output_html_with_http_headers', sub { ++$launched; } );
my $cgi=CGI->new;

5
t/db_dependent/Koha/UI/Form/Builder/Biblio.t
View File

@ -18,6 +18,7 @@
use Modern::Perl;
use Test::More tests => 7;
use Test::MockModule;
use C4::ClassSource;
@ -26,6 +27,10 @@ use Koha::DateUtils qw( dt_from_string );
use Koha::ItemTypes;
use Koha::Libraries;
# Auth required for cataloguing plugins
my $mAuth = Test::MockModule->new('C4::Auth');
$mAuth->mock( 'check_cookie_auth', sub { return ('ok') } );
my $schema = Koha::Database->new->schema;
$schema->storage->txn_begin;

5
t/db_dependent/Koha/UI/Form/Builder/Item.t
View File

@ -17,6 +17,7 @@
use Modern::Perl;
use Test::More tests => 9;
use Test::MockModule;
use Data::Dumper qw( Dumper );
use utf8;
@ -28,6 +29,10 @@ use Koha::UI::Form::Builder::Item;
use t::lib::TestBuilder;
use t::lib::Mocks;
# Auth required for cataloguing plugins
my $mAuth = Test::MockModule->new('C4::Auth');
$mAuth->mock( 'check_cookie_auth', sub { return ('ok') } );
my $schema = Koha::Database->new->schema;
$schema->storage->txn_begin;