From 3e77aedf690cbfcb1816a517b701c0e68e1d5601 Mon Sep 17 00:00:00 2001 From: Courtney Brown Date: Thu, 17 Jul 2025 23:09:15 +0000 Subject: [PATCH] Bug 35237: Give patron card layout form elements unique IDs This patch ensures the following patron card layout form fields use unique IDs: - page side - guide box - guide grid This semantically links the options to their labels so is more accessible for screen readers and keyboard navigation. The patch also adds a 'default' option to the original labels so they can become useful elements on the form rather than just text labels. Test plan: 1. Head to 'tools' then 'patron card creator' 2. Click on 'Layouts' underneath 'Manage' 3. Click on 'Edit' 4. Confirm it's easy to tell which options are available and chosen for page side, guide box, and guide grid 5. Click on the text labels for the options i.e. front, back, on, off. Confirm the relevant radio button is selected Sponsored-by: Catalyst IT Signed-off-by: Noah Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit fc9fc133b0a003e2b97a12b9b034b2d9a15a82ad) Signed-off-by: Jacob O'Mara --- .../en/modules/patroncards/edit-layout.tt | 24 ++++++++++++------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt index c4c9c65814..e227d8fe8e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt @@ -80,27 +80,33 @@
  • - + [% IF ( page_side ) %] - Front Back + + [% ELSE %] - Front Back + + [% END %]
  • - + [% IF ( guide_box ) %] - On Off + + [% ELSE %] - On Off + + [% END %]
  • - + [% IF ( guide_grid ) %] - On Off + + [% ELSE %] - On Off + + [% END %]