gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 10349 - Don't show empty Descriptions/Title notes tabs in OPAC and staff 

The descriptions/title notes tab appears on the detail page in both
staff client and OPAC even if there are no notes. This is probably a
relic of the pre-T:T days when it wasn't possible to use || in an IF.
This patch adds a check for the various variables which might trigger
the display of the tab.

To test, apply the patch and view records in the OPAC and staff client
which do and do not have title notes attached (whether that be in the
MARC record or in the biblio.notes column). In the OPAC Syndetics
content should also be tested if possible. The descriptions/title notes
tab should only appear if there is content.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
That's better - thx Owen!
Works nicely and passes all tests.
Tested in staff and OPAC, also in combination with NotesBlacklist
hiding all notes.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit f5c7badb31)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Works nicely.
This commit is contained in:
Owen Leonard 2013-05-31 12:05:49 -04:00 committed by Tomas Cohen Arazi
parent 09b01f2127
commit 3b9e88232d
2 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
View File

@ -343,7 +343,7 @@ function verify_images() {
[% ELSE %]
<li><a href="#holdings">Holdings</a></li>
[% END %]
<li><a href="#description">Descriptions</a></li>
[% IF ( MARCNOTES || notes ) %]<li><a href="#description">Descriptions</a></li>[% END %]
[% IF ( subscriptionsnumber ) %]<li><a href="#subscriptions">Subscriptions</a></li>[% END %]
[% IF ( FRBRizeEditions ) %][% IF ( XISBNS ) %]<li><a href="#editions">Editions</a></li>[% END %][% END %]
[% IF ( LocalCoverImages ) %][% IF ( localimages || CAN_user_tools_upload_local_cover_images ) %]<li><a href="#images">Images</a></li>[% END %][% END %]
@ -562,7 +562,9 @@ function verify_images() {
[% END %]
</div>
[% END %]
[% IF ( MARCNOTES || notes ) %]
<div id="description">
<div class="content_set">
@ -578,6 +580,8 @@ function verify_images() {
</div>
</div>
[% END %]
[% IF ( subscriptionsnumber ) %]
<div id="subscriptions">
<div class="yui-g">

8
koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
View File

@ -912,7 +912,9 @@ YAHOO.util.Event.onContentReady("furtherm", function () {
[% IF (SeparateHoldings) %]
<li><a href="#otherholdings">Other holdings ( [% otheritemloop.size || 0 %] )</a></li>
[% END %]
<li id="tab_descriptions"> <a href="#descriptions">Title notes</a></li>
[% IF ( MARCNOTES || notes || ( SyndeticsEnabled && SyndeticsSummary && SYNDETICS_SUMMARY )) %]
<li id="tab_descriptions"> <a href="#descriptions">Title notes</a></li>
[% END %]
[% IF ( SYNDETICS_TOC ) %]
<li id="tab_toc"> <a href="#toc">TOC</a></li>
[% END %]
@ -1050,6 +1052,8 @@ YAHOO.util.Event.onContentReady("furtherm", function () {
</div>
[% END %]
[% IF ( MARCNOTES || notes || ( SyndeticsEnabled && SyndeticsSummary && SYNDETICS_SUMMARY )) %]
<div id="descriptions">
<div class="content_set">
@ -1077,6 +1081,8 @@ YAHOO.util.Event.onContentReady("furtherm", function () {
</div>
</div>
[% END %]
[% IF ( SyndeticsEnabled ) %]
[% IF ( SyndeticsTOC ) %][% IF ( SYNDETICS_TOC ) %]