gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 14298: Add warning to the about page if the sco user does not have correct permissions 

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Note: Made a little change, changed He should have, to They should have

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(cherry picked from commit f2663af7d1)
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
This commit is contained in:
Jonathan Druart 2015-09-02 16:30:15 +01:00 committed by Liz Rea
parent 03c95d38e3
commit 39e5ecc7ac
2 changed files with 40 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
about.pl
View File

@ -190,6 +190,34 @@ if ( !defined C4::Context->config('use_zebra_facets') ) {
}
}
# Sco Patron should not contain any other perms than circulate => self_checkout
if ( C4::Context->preference('WebBasedSelfCheck')
and C4::Context->preference('AutoSelfCheckAllowed')
) {
my $userid = C4::Context->preference('AutoSelfCheckID');
my $all_permissions = C4::Auth::get_user_subpermissions( $userid );
my ( $has_self_checkout_perm, $has_other_permissions );
while ( my ( $module, $permissions ) = each %$all_permissions ) {
if ( $module eq 'circulate' ) {
while ( my ( $permission, $flag ) = each %$permissions ) {
if ( $permission eq 'self_checkout' ) {
$has_self_checkout_perm = 1;
} else {
$has_other_permissions = 1;
}
}
} else {
$has_other_permissions = 1;
}
}
$template->param(
AutoSelfCheckPatronDoesNotHaveSelfCheckPerm => not ( $has_self_checkout_perm ),
AutoSelfCheckPatronHasTooManyPerm => $has_other_permissions,
);
}
$template->param(
kohaVersion => $kohaVersion,
osVersion => $osVersion,

14
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
View File

@ -101,7 +101,7 @@
<div id="sysinfo">
[% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatron ||
warnNoActiveCurrency || QueryParserError || warnIsRootUser || xml_config_warnings.size %]
warnNoActiveCurrency || QueryParserError || warnIsRootUser || xml_config_warnings.size || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm %]
[% IF (warnIsRootUser) %]
<h2>Warning regarding current user</h2>
<p>You are logged in as the database administrative user. This is not recommended because some parts of Koha will not function as expected when using this account.</p>
@ -109,7 +109,7 @@
[% END %]
[% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatron ||
warnNoActiveCurrency || QueryParserError %]
warnNoActiveCurrency || QueryParserError || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm %]
<h2>Warnings regarding the system configuration</h2>
<table>
<caption>Preferences and parameters</caption>
@ -137,6 +137,16 @@
</td>
</tr>
[% END %]
[% IF AutoSelfCheckPatronDoesNotHaveSelfCheckPerm %]
<tr><th scope="row"><b>Warning</b> </th><td>
The patron used for the self checkout module at the OPAC does not have the circulate => self_checkout permission.
</td></tr>
[% END %]
[% IF AutoSelfCheckPatronHasTooManyPerm %]
<tr><th scope="row"><b>Warning</b> </th><td>
The patron used for the self checkout module at the OPAC has too many permissions. They should only have circulate => self_checkout.
</td></tr>
[% END %]
</table>
[% END %]