gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 18958: Unit tests 

Signed-off-by: Bonnie Gardner <bgardner@cityoflewiston.org>
Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

JD amended patch: perltidy and simplify item/biblio creation

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 7ee2495f32)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit e4b60c4156)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
This commit is contained in:
Nick Clemens 2019-08-12 18:41:24 +00:00 committed by Aleisha Amohia
parent af55420957
commit 39dd8a565d
1 changed files with 79 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

80
t/db_dependent/Reserves.t
View File

@ -17,7 +17,7 @@
use Modern::Perl;
use Test::More tests => 62;
use Test::More tests => 63;
use Test::MockModule;
use Test::Warn;
@ -875,6 +875,84 @@ subtest 'MoveReserve additional test' => sub {
};
subtest 'CheckReserves additional test' => sub {
plan tests => 3;
my $item = $builder->build_sample_item;
my $reserve1 = $builder->build_object(
{
class => "Koha::Holds",
value => {
found => undef,
priority => 1,
itemnumber => undef,
biblionumber => $item->biblionumber,
waitingdate => undef,
cancellationdate => undef,
item_level_hold => 0,
lowestPriority => 0,
expirationdate => undef,
suspend_until => undef,
suspend => 0,
itemtype => undef,
}
}
);
my $reserve2 = $builder->build_object(
{
class => "Koha::Holds",
value => {
found => undef,
priority => 2,
biblionumber => $item->biblionumber,
borrowernumber => $reserve1->borrowernumber,
itemnumber => undef,
waitingdate => undef,
cancellationdate => undef,
item_level_hold => 0,
lowestPriority => 0,
expirationdate => undef,
suspend_until => undef,
suspend => 0,
itemtype => undef,
}
}
);
my $tmp_holdsqueue = $builder->build(
{
source => 'TmpHoldsqueue',
value => {
borrowernumber => $reserve1->borrowernumber,
biblionumber => $reserve1->biblionumber,
}
}
);
my $fill_target = $builder->build(
{
source => 'HoldFillTarget',
value => {
borrowernumber => $reserve1->borrowernumber,
biblionumber => $reserve1->biblionumber,
itemnumber => $item->itemnumber,
item_level_request => 0,
}
}
);
ModReserveAffect( $item->itemnumber, $reserve1->borrowernumber, 1,
$reserve1->reserve_id );
my ( $status, $matched_reserve, $possible_reserves ) =
CheckReserves( $item->itemnumber );
is( $status, 'Reserved', "We found a reserve" );
is( $matched_reserve->{reserve_id},
$reserve1->reserve_id, "We got the Transit reserve" );
is( scalar @$possible_reserves, 1, 'We only get the one matched' );
};
sub count_hold_print_messages {
my $message_count = $dbh->selectall_arrayref(q{
SELECT COUNT(*)