Bug 23215: Remove PayPal-related sysprefs

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

installer/data/mysql/atomicupdate/bug_23215.perl

@@ -0,0 +1,17 @@
+$DBversion = 'XXX';
+if( CheckVersion( $DBversion ) ) {
+
+    $dbh->do(q{
+        DELETE FROM systempreferences
+        WHERE variable IN
+            ('EnablePayPalOpacPayments',
+             'PayPalChargeDescription',
+             'PayPalPwd',
+             'PayPalReturnURL',
+             'PayPalSandboxMode',
+             'PayPalSignature',
+             'PayPalUser');
+    });
+
+    NewVersion( $DBversion, 23215, "Remove core PayPal support in favor of the use of plugins");
+}

installer/data/mysql/mandatory/sysprefs.sql

@@ -523,14 +523,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
 ('PatronSelfRegistrationPrefillForm','1',NULL,'Display password and prefill login form after a patron has self registered','YesNo'),
 ('PatronSelfRegistrationVerifyByEmail','0',NULL,'If enabled, any patron attempting to register themselves via the OPAC will be required to verify themselves via email to activate their account.','YesNo'),
 ('PatronsPerPage','20','20','Number of Patrons Per Page displayed by default','Integer'),
-('EnablePayPalOpacPayments',  '0', NULL ,  'Enables the ability to pay fees and fines from  the OPAC via PayPal',  'YesNo' ),
 ('PatronQuickAddFields',  '', NULL ,  'A list of fields separated by "|" to be displayed along with mandatory fields in the patron quick add form if chosen at patron entry',  'Free' ),
-('PayPalChargeDescription',  'Koha fee payment', NULL ,  'This preference defines what the user will see the charge listed as in PayPal',  'Free'),
-('PayPalPwd',  '', NULL ,  'Your PayPal API password',  'Free'),
-('PayPalReturnURL','BaseURL','BaseURL|OPACAlias','Specify whether PayPal will return to the url specified in the OPACBaseURL option or to the OPAC\'s alias url.','Choice'),
-('PayPalSandboxMode',  '1', NULL ,  'If enabled, the system will use PayPal''s sandbox server for testing, rather than the production server.',  'YesNo'),
-('PayPalSignature',  '', NULL ,  'Your PayPal API signature',  'Free'),
-('PayPalUser',  '', NULL ,  'Your PayPal API username ( email address )',  'Free'),
 ('PhoneNotification','0',NULL,'If ON, enables generation of phone notifications to be sent by plugins','YesNo'),
 ('PrefillGuaranteeField', 'phone,email,streetnumber,address,city,state,zipcode,country', NULL, 'Prefill these fields in guarantee member entry form from guarantor patron record', 'Multiple'),
 ('PrefillItem','0','','When a new item is added, should it be prefilled with last created item values?','YesNo'),

koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref

@@ -893,49 +893,6 @@ OPAC:
                 subtype: Subtypes
                 sorting: Sorting
                 location: Location and availability
-    Payments:
-        -
-            - pref: EnablePayPalOpacPayments
-              default: 1
-              choices:
-                  1: Allow
-                  0: "Don't allow"
-            - "patrons to make payments from the OPAC via PayPal in"
-            - pref: PayPalSandboxMode
-              default: 1
-              choices:
-                  1: "sandbox"
-                  0: "production"
-            - "mode."
-            - "<br/><strong>Warning</strong>: this functionality has been deprecated in favor of using payment plugins that can implement different payment services."
-        -
-            - "The email address to receive PayPal payments is "
-            - pref: PayPalUser
-              class: email
-            - "."
-        -
-            - "The password for the PayPal account to receive payments is "
-            - pref: PayPalPwd
-              class: long
-            - "."
-        -
-            - "The signature for the PayPal account to receive payments is "
-            - pref: PayPalSignature
-              class: long
-            - "."
-        -
-            - "The patron should see the charge description as "
-            - pref: PayPalChargeDescription
-              class: long
-            - "."
-        -
-            - "After payment or cancellation, PayPal should return to the "
-            - pref: PayPalReturnURL
-              default: BaseURL
-              choices:
-                  BaseURL: "OPACBaseURL"
-                  OPACAlias: "configured return URL"
-            - "."
     Authentication:
         -
             - pref: OPACShibOnly