gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 11885: (follow-up) make default styling consistent with previous look 

Jonathan Druart raised the following three issues:
1/ subtags was bold before patch
2/ 1 dash existed between tag and tag name
3/ A space has been added ("606 #1 - Sujet nom commun"
    becomes "606 # 1 Sujet nom commun",  "101 ## - Langue"
    becomes "101 # # Langue")

This patch addresses them in the following way:
1/ You will note that @ was not bold on the 0 tab.
   Every other tab were bold. By making the similar template
   into a procedure based on the 0XX tab, bolding was lost.
   This patch bolds all subtags including the @, so that
   the visible change is minimized.
2/ The dash was programmatically added in at the code stage
   previously. This bug fix splits the the single concatenation
   mess into parts which can be styled. This puts the dash back
   into the template. However, it should be noted that the
   spacing for the 0 tab's tag and tag description will have an
   extra space after the hypen that was lacking before.
3/ <span>...</span><span>...</span> is different than
   <span>...</span>
   <span>...</span>
   The later puts that extra space. This patch fixes that.

See comment 1 for the test plan.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Work as described.
Small koha-qa errors fixed in followup

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
This commit is contained in:
Mark Tompsett 2014-04-02 20:22:44 -04:00 committed by Galen Charlton
parent 0ea17a6a76
commit 377dbfc73f
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
View File

@ -78,10 +78,9 @@ function Changefwk(FwkList) {
<div class="tag_title">
<span class="tag_num">[% tab0X.tag %]</span>
[% IF ( tab0X.tag_ind ) %]
<span class="tag_ind1">[% tab0X.tag_ind.substr(0, 1) %]</span>
<span class="tag_ind2">[% tab0X.tag_ind.substr(1, 1) %]</span>
<span class="tag_ind1">[% tab0X.tag_ind.substr(0, 1) %]</span><span class="tag_ind2">[% tab0X.tag_ind.substr(1, 1) %]</span>
[% END %]
[% IF (tab0X.tag_desc) %]<span class="tag_desc">[% tab0X.tag_desc %]</span>[% END %]
[% IF (tab0X.tag_desc) %]<span class="dashwrapper"> -</span> <span class="tag_desc">[% tab0X.tag_desc %]</span>[% END %]
</div>
[% ELSE %]
<div class="tag">
@ -89,7 +88,7 @@ function Changefwk(FwkList) {
[% FOREACH subfiel IN tab0X.subfield %]
<p class="subfield_line">
<span class="subfield-label">&nbsp;
[% UNLESS ( subfiel.hide_marc ) %][% subfiel.marc_subfield %][% END %]
[% UNLESS ( subfiel.hide_marc ) %]<b>[% subfiel.marc_subfield %]</b>[% END %]
<span class="desc" title="[% subfiel.long_desc %]">[% subfiel.short_desc %]</span></span>
[% IF ( subfiel.is_url ) %]<a href="[% subfiel.marc_value %]">[% subfiel.marc_value |html %]</a>[% ELSE %][% subfiel.marc_value |html %][% END %]
[% IF ( subfiel.link ) %]