gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 42746: Sanitize condition and substitution fields 

Signed-off-by: Sanjar Tulkinov Anvar o'g'li <sanjarbiy11@gmail.com>

Amended-by: Jonathan Druart:
Replace , with ;

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
(cherry picked from commit 3b53d6711d)
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
This commit is contained in:
Jonathan Druart 2026-06-02 14:14:34 +02:00 committed by Baptiste Wojtkowski
parent f7194d2173
commit 3624bf8caa
No known key found for this signature in database
GPG Key ID: 47A8A13E10BC0D40
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/automatic_item_modification_by_age.pl
View File

@ -60,6 +60,8 @@ my $op = $cgi->param('op') // 'show';
my @item_fields = map { "items.$_" } Koha::Items->columns;
my @biblioitem_fields = map { "biblioitems.$_" } Koha::Biblioitems->columns;
my @biblio_fields = map { "biblio.$_" } Koha::Biblios->columns;
my @allowed_condition_fields = ( @item_fields, @biblioitem_fields, @biblio_fields );
my @allowed_substitution_fields = @item_fields;
my @allowed_age_fields = (
'items.dateaccessioned', 'items.replacementpricedate', 'items.datelastborrowed', 'items.datelastseen',
'items.damaged_on', 'items.itemlost_on', 'items.withdrawn_on'
@ -82,6 +84,7 @@ if ( $op eq 'cud-update' ) {
for my $value ( @substitution_values ) {
my $field = shift @substitution_fields;
last unless $field;
next unless grep { $_ eq $field } @allowed_substitution_fields;
push @{ $rule->{substitutions} }, { field => $field, value => $value };
}
push @{ $rule->{substitutions} }, {}
@ -89,6 +92,7 @@ if ( $op eq 'cud-update' ) {
for my $value ( @condition_values ) {
my $field = shift @condition_fields;
last unless $field;
next unless grep { $_ eq $field } @allowed_condition_fields;
push @{ $rule->{conditions} }, { field => $field, value => $value };
}
push @{ $rule->{conditions} }, {}
@ -125,9 +129,9 @@ if ( $@ ) {
$template->param(
op => $op,
messages => \@messages,
agefields => [@allowed_age_fields],
condition_fields => [ @item_fields, @biblioitem_fields, @biblio_fields ],
substitution_fields => \@item_fields,
agefields => \@allowed_age_fields,
condition_fields => \@allowed_condition_fields,
substitution_fields => \@allowed_substitution_fields,
rules => $rules,
);