gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 29697: Fix t/db_dependent/Exporter/Record.t 

Not sure about the warn, we shouldn't need it as we are raising an
exception. But better (for now) than introducing regressions.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Jonathan Druart 2022-07-25 14:26:27 +02:00 committed by Tomas Cohen Arazi
parent f275de1f4f
commit 336951673c
No known key found for this signature in database
GPG Key ID: 0A272EA1B2F3C15F
3 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
C4/Record.pm
View File

@ -460,7 +460,10 @@ sub marcrecord2csv {
# Getting the record
my $biblio = Koha::Biblios->find($biblionumber);
return unless $biblio;
my $record = $biblio->metadata->record({ embed_items => 1, itemnumbers => $itemnumbers });
my $record = eval {
$biblio->metadata->record(
{ embed_items => 1, itemnumbers => $itemnumbers } );
};
return unless $record;
# Getting the framework
my $frameworkcode = $biblio->frameworkcode;

1
Koha/Biblio/Metadata.pm
View File

@ -111,6 +111,7 @@ sub record {
my $marcxml_error = $@;
chomp $marcxml_error;
unless ($record) {
warn $marcxml_error;
Koha::Exceptions::Metadata::Invalid->throw(
id => $self->id,
biblionumber => $self->biblionumber,

12
Koha/Exporter/Record.pm
View File

@ -127,10 +127,14 @@ sub _get_biblio_for_export {
return if $@ or not defined $record;
if ($export_items) {
C4::Biblio::EmbedItemsInMarcBiblio({
marc_record => $record,
biblionumber => $biblionumber,
item_numbers => $itemnumbers });
Koha::Biblio::Metadata->record(
{
record => $record,
embed_items => 1,
biblionumber => $biblionumber,
item_numbers => $itemnumbers,
}
);
if ($only_export_items_for_branches && @$only_export_items_for_branches) {
my %export_items_for_branches = map { $_ => 1 } @$only_export_items_for_branches;
my ( $homebranchfield, $homebranchsubfield ) = GetMarcFromKohaField( 'items.homebranch' );