Bug 20499: Fix the Internal Server Error

TEST PLAN
---------
See comment #1

Applying the test without the patch: messy.
Applyin both patches: smooth.
Run koha qa test tools

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Mark Tompsett 2018-03-29 18:47:25 +00:00 committed by Jonathan Druart
parent c43af09eb4
commit 32b6c50855
1 changed files with 6 additions and 6 deletions

View File

@ -669,6 +669,12 @@ sub CanBookBeIssued {
my $override_high_holds = $params->{override_high_holds} || 0;
my $item = GetItem(undef, $barcode );
# MANDATORY CHECKS - unless item exists, nothing else matters
unless ( $item->{barcode} ) {
$issuingimpossible{UNKNOWN_BARCODE} = 1;
}
return ( \%issuingimpossible, \%needsconfirmation ) if %issuingimpossible;
my $issue = Koha::Checkouts->find( { itemnumber => $item->{itemnumber} } );
my $biblio = Koha::Biblios->find( $item->{biblionumber} );
my $biblioitem = $biblio->biblioitem;
@ -676,12 +682,6 @@ sub CanBookBeIssued {
my $dbh = C4::Context->dbh;
my $patron_unblessed = $patron->unblessed;
# MANDATORY CHECKS - unless item exists, nothing else matters
unless ( $item->{barcode} ) {
$issuingimpossible{UNKNOWN_BARCODE} = 1;
}
return ( \%issuingimpossible, \%needsconfirmation ) if %issuingimpossible;
#
# DUE DATE is OK ? -- should already have checked.
#