gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 25641: Fix Koha/XSLT/Base.t failures on U20 

There is a change in the version number.
On U20 we get
  Opening and ending tag mismatch: a line 0 and b
On others (D9, D10, U18) we get:
  Opening and ending tag mismatch: a line 1 and b

I did not find where it did come from, so assuming it's just a minor
change and won't have side-effects.

Test plan:
Make sure the tests pass on U20 and another OS

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Jonathan Druart 2020-06-01 12:54:03 +02:00
parent 7df314f0b2
commit 2f828d433d
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
t/db_dependent/Koha/XSLT/Base.t
View File

@ -84,7 +84,7 @@ is( $engine->err, Koha::XSLT::Base::XSLTH_ERR_5, 'Engine returns error on non-xm
# Malformed XML tests
warning_like { $output = $engine->transform({ xml => '<a></b>', code => $xsl_1 }) }
qr{parser error : Opening and ending tag mismatch: a line 1 and b},
qr{parser error : Opening and ending tag mismatch: a line (0|1) and b},
"Malformed XML warning correctly displayed";
is( $engine->err, Koha::XSLT::Base::XSLTH_ERR_5, 'Engine returns error on malformed xml' );
@ -96,18 +96,18 @@ my $secondengine=Koha::XSLT::Base->new( {
});
$engine->do_not_return_source(1);
warning_like { $output = $engine->transform({ xml => '<a></b>', code => $xsl_1 }) }
qr{parser error : Opening and ending tag mismatch: a line 1 and b},
qr{parser error : Opening and ending tag mismatch: a line (0|1) and b},
"Malformed XML warning correctly displayed";
is( defined $output? 1: 0, 0, 'Engine respects do_not_return_source==1');
$secondengine->print_warns(1);
warning_like { $output = $secondengine->transform({ xml => '<a></b>', code => $xsl_1 }) }
qr{parser error : Opening and ending tag mismatch: a line 1 and b},
qr{parser error : Opening and ending tag mismatch: a line (0|1) and b},
"Malformed XML warning correctly displayed";
is( defined $output? 1: 0, 0, 'Second engine respects it too');
undef $secondengine; #bye
$engine->do_not_return_source(0);
warning_like { $output = $engine->transform({ xml => '<a></b>', code => $xsl_1 }) }
qr{parser error : Opening and ending tag mismatch: a line 1 and b},
qr{parser error : Opening and ending tag mismatch: a line (0|1) and b},
"Malformed XML warning correctly displayed";
is( defined $output? 1: 0, 1, 'Engine respects do_not_return_source==0');