Bug 37634: Missing "USE Koha" causes JS errors and missing "Last patron" menu

This patch adds "[% USE Koha %]" to templates which lack it. Without
this, the "Last patron" menu item doesn't work and will cause a JS error
on many pages. The patch also removes some USE entries which were
duplicates.

To test, apply the patch and test all 176 different pages to confirm
they all work correctly. I mean, maybe. Or maybe sample a few to confirm
they work?

- Go to Administration -> System preferences and enable "showLastPatron"
- If the preference was not enabled, you probably need to go to
  Circulation and open a patron account for checkout so that there is a
  "last patron" to show.
- Test a sampling of pages affected by this patch:
  - Acquisitions -> Acquisitions home page
  - Administration -> Cities and towns
  - Catalog -> Item search
  - Cataloging -> Label creator
  - Patrons -> Patron account -> Set permissions
  - Reports -> Items lost
  - Serials -> Serials home page
  - Tools -> Calendar
- Pages which had duplicate lines (not necessarily "USE Koha"):
  - Acquisitions -> Vendor -> Receive shipments
  - Administration -> Manage jobs
  - Administration -> Record overlay rules
  - Catalog -> Search results
  - Catalog -> Bibliographic detail page -> Items
  - Circulation -> Holds queue
  - Patrons -> Patron detail page -> Accounting -> Transactions tab
  - Serials -> Subscription details -> Create/edit routing list
  - OPAC -> Search results -> Request article

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 210b93abac)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Owen Leonard 2024-11-25 18:56:56 +00:00 committed by Paul Derscheid
parent ff400e8e89
commit 2c7bfbba8e
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
175 changed files with 168 additions and 9 deletions

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE AdditionalContents %]
[% USE Asset %]
[% USE Price %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE KohaDates %]
[% USE Branches %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE AuthorisedValues %]
[% USE KohaDates %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% PROCESS 'i18n.inc' %]
[% INCLUDE 'doc-head-open.inc' %]
<title>[% FILTER collapse %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE KohaDates %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% PROCESS 'i18n.inc' %]
[% INCLUDE 'doc-head-open.inc' %]
<title>[% FILTER collapse %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE KohaDates %]
[% USE TablesSettings %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE KohaDates %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE AuthorisedValues %]
[% USE KohaDates %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE KohaDates %]
[% USE Branches %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE KohaDates %]
[% SET footerjs = 1 %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% PROCESS 'i18n.inc' %]
[% INCLUDE 'doc-head-open.inc' %]
<title>[% FILTER collapse %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% PROCESS 'i18n.inc' %]
[% INCLUDE 'doc-head-open.inc' %]
<title>[% FILTER collapse %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Branches %]
[% USE Price %]
[% USE Asset %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE KohaDates %]
[% USE ItemTypes %]

View File

@ -1,9 +1,9 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE KohaDates %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]
[% PROCESS 'i18n.inc' %]
[% INCLUDE 'doc-head-open.inc' %]
<title>[% FILTER collapse %]
[% tx("Receive shipment from vendor {vendor}", { vendor = name }) | html %] &rsaquo;

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE KohaDates %]
[% USE ItemTypes %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE To %]
[% USE Asset %]
[% USE KohaDates %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE AuthorisedValues %]
[% USE KohaDates %]

View File

@ -1,3 +1,4 @@
[% USE Koha %]
[% USE AuthorisedValues %]
[% USE raw %]
[% USE Asset %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE KohaDates %]
[% USE Price %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE KohaDates %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE Price %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE AuthorisedValues %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,5 +1,5 @@
[% USE raw %]
[% USE KohaDates %]
[% USE Koha %]
[% USE Asset %]
[% USE KohaDates %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE Branches %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE Branches %]
[% USE Price %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE TablesSettings %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE Branches %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE TablesSettings %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE Branches %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE KohaDates %]
[% USE TablesSettings %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE Branches %]
[% USE Price %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Branches %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE Branches %]
[% USE Categories %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE Branches %]
[% USE Categories %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE Branches %]
[% USE Price %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE Branches %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE AuthorisedValues %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE KohaSpan %]
[% PROCESS 'i18n.inc' %]

View File

@ -5,7 +5,6 @@
[% USE KohaSpan %]
[% USE Categories %]
[% PROCESS 'i18n.inc' %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %]
<title>[% FILTER collapse %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE AuthorisedValues %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE I18N %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE Branches %]
[% USE HtmlTags %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE AuthorisedValues %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE AuthorisedValues %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE Branches %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE HtmlTags %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE To %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% PROCESS 'merge-record.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE KohaDates %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE To %]
[% USE Asset %]
[% USE AuthorisedValues %]

View File

@ -1,5 +1,4 @@
[% USE raw %]
[% USE Price %]
[% USE Asset %]
[% USE Koha %]
[% USE Branches %]

View File

@ -5,7 +5,6 @@
[% USE Biblio %]
[% USE KohaDates %]
[% USE KohaPlugins %]
[% USE To %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]
[% SET CoverImagePlugins = KohaPlugins.get_plugins_intranet_cover_images %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE AuthorisedValues %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE HtmlTags %]
[% PROCESS 'i18n.inc' %]
[% INCLUDE 'doc-head-open.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE KohaDates %]
[% USE AuthorisedValues %]

View File

@ -6,7 +6,6 @@
[% USE Branches %]
[% USE AuthorisedValues %]
[% USE TablesSettings %]
[% USE Koha %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE HtmlTags %]
[% USE KohaDates %]
[% USE Branches %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Branches %]
[% USE AuthorisedValues %]
[% USE HtmlTags %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE HtmlTags %]
[% USE Branches %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE AuthorisedValues %]
[% USE Branches %]
[% USE ItemTypes %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE HtmlTags %]
[% USE Asset %]
[% USE AuthorisedValues %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE AuthorisedValues %]
[% USE TablesSettings %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE HtmlTags %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% PROCESS 'i18n.inc' %]
[% INCLUDE 'doc-head-open.inc' %]
<title>[% FILTER collapse %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% PROCESS 'i18n.inc' %]
[% INCLUDE 'doc-head-open.inc' %]
<title>[% FILTER collapse %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE ItemTypes %]
[% PROCESS 'i18n.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]
[%- BLOCK translate_label_types -%]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[%- USE Price -%]
[%- USE KohaDates -%]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE AuthorisedValues %]
[% USE Branches %]

View File

@ -6,7 +6,6 @@
[% USE TablesSettings %]
[% USE AuthorisedValues %]
[% USE Price %]
[% USE Branches %]
[% USE Registers %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]

View File

@ -1,4 +1,5 @@
[% USE raw %]
[% USE Koha %]
[% USE Asset %]
[% USE Price %]
[% USE Branches %]

Some files were not shown because too many files have changed in this diff Show More