gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 20806: Do not rely on column position 

It is not the first time we have this splice call, it seems safer to
rely on the column's name instead of the column's position

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2018-06-29 17:30:39 -03:00 committed by Nick Clemens
parent 0c1490ec71
commit 2a369663fd
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt
View File

@ -125,7 +125,7 @@
var columns_settings = [% ColumnsSettings.GetColumns('members', 'holdshistory', 'holdshistory-table', 'json') %];
[% UNLESS show_itemtype_column %]
//Remove item type column settings
columns_settings.splice(8,1);
columns_settings = columns_settings.filter(function(c){return c['columnname'] != 'itemtype';});
[% END %]
var table = KohaTable("table_holdshistory", {
"sPaginationType": "four_button",