gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 23916: (follow-up) Fix unit test 

This commit responds to the comment made by Katrin in comment #73. I
have removed the lines cited as causing the contraint violation. The
were added in the original iteration of the bug patches and, despite
spending time trying to get to the bottom of it, I cannot figure out
why. There are no changes in the patchset relating to Koha/Patron.pm and
removing the lines does not cause any of the tests in files that *are*
affected by this patchset to fail. I do not know why these lines were
ever added in the first place, unfortunately I did not add comments
explaining (lesson learned)!

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Andrew Isherwood 2020-10-23 11:55:44 +01:00 committed by Jonathan Druart
parent 4defe532df
commit 27d64e1720
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
t/db_dependent/Koha/Patrons.t
View File

@ -1430,13 +1430,6 @@ subtest 'get_overdues' => sub {
value => { branchcode => $library->{branchcode} }
}
);
my $issuer = $builder->build(
{
source => 'Borrower',
value => { branchcode => $library->{branchcode} }
}
);
t::lib::Mocks::mock_userenv({ number => $issuer->{borrowernumber} });
t::lib::Mocks::mock_preference({ branchcode => $library->{branchcode} });