gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 43259: Fix add/remove basket to/from group 

Caused by
  commit e9b8004d19
  Bug 38255: Replace dataTable constructor with kohaTable - Staff

grouped and ungrouped should be DataTable objects.

Test plan:
Create a basket, close it
Create a basket group and test the "Add to group" and "Remove" button on
the basket group edit view

Without this patch there was a JS error:
"Uncaught TypeError: grouped.row is not a function"

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
This commit is contained in:
Jonathan Druart 2026-08-24 16:05:56 +02:00 committed by Pedro Amorim
parent 8870a456dc
commit 274432cd68
No known key found for this signature in database
GPG Key ID: 06B75BA7F3894D55
1 changed files with 23 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
View File

@ -434,6 +434,7 @@
$("#basket_groups a[href='#opened_panel']").tab("show");
}
let grouped_dt, ungrouped_dt;
if (!grouping) {
let dt_params = {
autoWidth: false,
@ -444,20 +445,24 @@
$("#basket_group_opened").kohaTable(dt_params);
$("#basket_group_closed").kohaTable(dt_params);
} else {
grouped = $("#grouped").kohaTable({
dom: "t",
autoWidth: false,
language: {
emptyTable: _("There are no baskets in this group"),
},
});
ungrouped = $("#ungrouped").kohaTable({
dom: "t",
autoWidth: false,
language: {
emptyTable: _("There are no ungrouped baskets"),
},
});
grouped_dt = $("#grouped")
.kohaTable({
dom: "t",
autoWidth: false,
language: {
emptyTable: _("There are no baskets in this group"),
},
})
.DataTable();
ungrouped_dt = $("#ungrouped")
.kohaTable({
dom: "t",
autoWidth: false,
language: {
emptyTable: _("There are no ungrouped baskets"),
},
})
.DataTable();
}
$("#basketgroupcolumns").on("click", ".addtogroup", function () {
@ -468,8 +473,8 @@
.addClass("removefromgroup")
.html('<i class="fa fa-trash-can" aria-hidden="true"></i> ' + _("Remove"));
row.removeClass("ungrouped").addClass("grouped");
ungrouped.row(row).remove().draw();
grouped.row.add(row).draw();
ungrouped_dt.row(row).remove().draw();
grouped_dt.row.add(row).draw();
}
});
@ -482,8 +487,8 @@
.html('<i class="fa fa-plus" aria-hidden="true"></i> ' + _("Add to group"));
$(this).removeClass("").addClass("");
row.removeClass("grouped").addClass("ungrouped");
grouped.row(row).remove().draw();
ungrouped.row.add(row).draw();
grouped_dt.row(row).remove().draw();
ungrouped_dt.row.add(row).draw();
}
});