Bug 29571: (follow-up) Fix display of pending suggestions in acqui-home.tt

In addition to the Staff Client's home page, the number of pending
suggestions is also displayed in Home > Acquisitions. Currently,
these are only displayed if there are pending suggestions at the
logged in library. However, suggestions should always be displayed.

This follow-up patch fixes that, and also removes a template variable
(`suggestion`) that is no longer in use (removed as part of Bug 4331,
commit 70af459372).

Test plan:
1) Create a suggestion for Library A.
2) Go to Home > Acquisitions while logged in at Library B.
   Without this patch, nothing is displayed regarding suggestions.
3) Apply this patch. Notice how suggestion information is shown, like:
   "Manage suggestions: Library B: 0 / All libraries: 1"
   If you change the library to Library A, you should get:
   "Manage suggestions: Library A: 1"

Signed-off-by: Florian Bontemps <florian.bontemps@biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit a43a171940)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
This commit is contained in:
Andreas Roussos 2021-12-13 07:49:07 +01:00 committed by Andrew Fuerste-Henry
parent 385393a566
commit 271e2b8c65
1 changed files with 2 additions and 2 deletions

View File

@ -41,7 +41,7 @@
[% END %]
[% END %]
<div class="row">
[% IF ( suggestion && suggestions_count ) %]
[% IF ( suggestions_count || all_pendingsuggestions ) %]
<div class="col-sm-6">
[% ELSE %]
<div class="col-sm-12">
@ -58,7 +58,7 @@
</div>
</div>
[% IF ( CAN_user_suggestions_suggestions_manage && suggestion && suggestions_count ) %]
[% IF ( CAN_user_suggestions_suggestions_manage && ( suggestions_count || all_pendingsuggestions ) ) %]
<div class="col-sm-6">
<div id="acqui_acqui_home_suggestions">
<fieldset>