From 2627cfbe1de105bb86015a2eb109a9c0d4b8cf87 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 21 Jun 2024 17:27:40 +0000 Subject: [PATCH] Bug 35808: Remove obsolete responsive table markup from several pages in the OPAC This patch removes span.tdlabel from several templates. The markup is obsolete now that we use the DataTables responsive feature. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Log in to the OPAC as a user with checkouts, suggestions, and tags. - Check these pages to confirm that the tables on each one have the correct responsive behavior at varying browser widths: - OPAC home -> Most popular - Your account - Your account -> Checkout history - Your account -> Suggestions - Your account -> Tags * The recalls history page is fixed in Bug 37158 Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda Signed-off-by: Katrin Fischer --- .../opac-tmpl/bootstrap/css/src/_responsive.scss | 4 ---- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 5 ----- .../bootstrap/en/modules/opac-readingrecord.tt | 3 --- .../bootstrap/en/modules/opac-suggestions.tt | 4 ---- .../opac-tmpl/bootstrap/en/modules/opac-tags.tt | 3 --- .../bootstrap/en/modules/opac-topissues.tt | 3 --- .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 15 --------------- 7 files changed, 37 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/_responsive.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/_responsive.scss index 3a2209f739..c0eb207a7c 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/css/src/_responsive.scss +++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/_responsive.scss @@ -99,10 +99,6 @@ margin-bottom: .5em; } - .table:not( .collapsed ) .tdlabel { - display: inline; - } - .table td.bibliocol { padding-left: 1.3em; } diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss index 2cfe371927..bc94fd539f 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss +++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss @@ -2170,11 +2170,6 @@ nav { z-index: 5; } -.tdlabel { - display: none; - font-weight: bold; -} - #ulactioncontainer { min-width: 16em; } diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt index 497ee3fbaa..24b95d3e5d 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt @@ -190,12 +190,10 @@ [% END %] [% END %] - Item type: [% item_type.translated_description | html %] - Call number: [% item.itemcallnumber | html %] @@ -205,7 +203,6 @@ [% IF checkout.returndate %] - Check-in date: [% checkout.returndate | $KohaDates %] [% ELSE %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt index 312015c6eb..1a9c43bc12 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt @@ -449,14 +449,12 @@ [% IF ( suggestion.note ) %] - Note: [% suggestion.note | html %] [% END %] [% IF Koha.Preference( 'OPACViewOthersSuggestions' ) == 1 %] [% IF suggestion.suggestedby %] - Suggested for: [% Branches.GetName(suggestion.branchcode) | html %] [% END %] @@ -464,14 +462,12 @@ [% IF Koha.Preference( 'OpacSuggestionManagedBy' ) %] [% IF suggestion.managedby %] - Managed by: [% INCLUDE 'patron-title.inc' patron = suggestion.manager %] [% IF ( suggestion.manageddate ) %] - [% suggestion.manageddate | $KohaDates %][% END %] [% END %] [% END %] - Status: [% IF ( suggestion.STATUS == 'ASKED' ) %]Requested [% ELSIF ( suggestion.STATUS == 'CHECKED' ) %]Checked by the library [% ELSIF ( suggestion.STATUS == 'ACCEPTED' ) %]Accepted by the library diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt index 7e6dfa05e9..9c167ad8d3 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt @@ -163,7 +163,6 @@ - Tag: [% IF MY_TAG.approved == 1 %] [% MY_TAG.term | html %] [% ELSE %] @@ -174,7 +173,6 @@ [% IF ( MY_TAG.XSLTBloc ) %] [% MY_TAG.XSLTBloc | $raw %] [% ELSE %] - Title: [% INCLUDE 'biblio-title.inc' biblio=MY_TAG link=> 1 %] [% IF ( MY_TAG.author ) %] by [% MY_TAG.author | html %] @@ -184,7 +182,6 @@ [% INCLUDE 'title-actions-menu.inc' items=MY_TAG %] - Date added: [% MY_TAG.date_created | $KohaDates %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt index 48bae524b2..0e34c229b6 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt @@ -109,15 +109,12 @@ [% IF ( result.item('size') ) %][% result.item('size') | html %][% END %]

- Item type [% ItemTypes.GetDescription(result.itemtype) | html %] - Collection [% AuthorisedValues.GetByCode('ccode', result.ccode, 1) | html %] - Checkouts: [% result.count | html %] [% IF Koha.Preference( 'opacuserlogin' ) == 1 %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt index a6295f4e12..30f6dd7c04 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt @@ -418,18 +418,15 @@ [% ISSUE.author | html %] [% IF ( ISSUE.overdue ) %] - Date due: [% ISSUE.date_due | $KohaDates as_due_date => 1 %] [% ELSE %] - Date due: [% ISSUE.date_due | $KohaDates as_due_date => 1 %] [% END %] [% IF ( Koha.Preference('BiblioItemtypeInfo') || !item_level_itypes ) %] - Item type: [% IF ( ISSUE.imageurl && !Koha.Preference('OpacNoItemTypeImages') ) %] [% ISSUE.description | html %] [% END %] [% ISSUE.description | html %] @@ -437,12 +434,10 @@ [% END %] [% IF ( show_barcode ) %] - Barcode: [% ISSUE.barcode | html %] [% END %] - Call number: [% ISSUE.itemcallnumber | html %] [% IF ( OpacRenewalAllowed && !( logged_in_user.is_expired && logged_in_user.category.effective_BlockExpiredPatronOpacActions_contains('renew') ) ) %] @@ -515,7 +510,6 @@ [% END %] [% IF ( OPACFinesTab ) %] - Fines: [% IF ( ISSUE.charges ) %] Yes (Item overdue or lost) [% ELSIF ( ISSUE.rentalfines ) %] @@ -785,16 +779,13 @@ [% END %] [% IF ( show_barcode ) %] - Barcode: [% OVERDUE.barcode | html %] [% END %] - Call number: [% OVERDUE.itemcallnumber | html %] - Date due: [% OVERDUE.date_due | $KohaDates as_due_date => 1 %] [% IF ( OpacRenewalAllowed ) %] @@ -822,7 +813,6 @@ [% END %] [% IF ( OPACFinesTab ) %] - Fines: [% IF ( OVERDUE.charges ) %] Yes [% ELSE %] @@ -868,29 +858,24 @@ - Recall date: [% RECALL.created_date | $KohaDates %] [% IF ( RECALL.expiration_date ) %] - Expiration: [% RECALL.expiration_date | $KohaDates %] [% ELSE %] - Expiration: Never expires [% END %] - Pick up location: [% RECALL.library.branchname | html %] - Status: [% IF ( RECALL.requested ) %] Requested [% ELSIF ( RECALL.overdue ) %]