Bug 16504: (follow-up for bug 15163) Do not remove attributes of other patrons

Simple patch for a silly error, this single line is going to fix a
critical bug.
If a patron attribute is limited to a library, all the values for that attributes
for every patrons will be deleted.

Test plan:
Create a patron attribute limited to a library
Set the the attribute for a patron
Set the the attribute for another patron
=> Without this patch applied, the attribute's value for the first
patron is deleted
=> With this patch applied, the 2 values exist in the DB after the
second edition

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit da94410ab5)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
This commit is contained in:
Jonathan Druart 2016-05-13 14:43:52 +01:00 committed by Frédéric Demians
parent 5949faae07
commit 247bd55876
1 changed files with 1 additions and 1 deletions

View File

@ -254,7 +254,7 @@ sub DeleteBorrowerAttributes {
$query .= $branch_limit
? q{
LEFT JOIN borrower_attribute_types_branches ON bat_code = code
WHERE b_branchcode = ? OR b_branchcode IS NULL
WHERE ( b_branchcode = ? OR b_branchcode IS NULL )
AND borrowernumber = ?
}
: q{