Bug 11349: Make the QA script happy

This patch just adjusts several POD stuff, and in a few cases
reorganizes a hash definition in order to use spaces instead of tabs
for the QA script to be happy.

Nothing important, really. This patch series just changes '.tmpl' for
'.tt'.

Regards
To+

PS beware that running the koha-qa.pl script can take lots of time on this one
:-D

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

authorities/detail-biblio-search.pl

@@ -62,14 +62,16 @@ my $tagslib = &GetTagsLabels(1,$authtypecode);
 
 my $record =GetAuthority($authid);
 # open template
-my ($template, $loggedinuser, $cookie)
-		= get_template_and_user({template_name => "authorities/detail-biblio-search.tt",
-			     query => $query,
-			     type => "intranet",
-			     authnotrequired => 0,
-			     flagsrequired => {catalogue => 1},
-			     debug => 1,
-			     });
+my ($template, $loggedinuser, $cookie) = get_template_and_user(
+    {
+        template_name   => "authorities/detail-biblio-search.tt",
+        query           => $query,
+        type            => "intranet",
+        authnotrequired => 0,
+        flagsrequired   => { catalogue => 1 },
+        debug           => 1,
+    }
+);
 
 # fill arrays
 my @loop_data =();

cataloguing/value_builder/marc21_leader_computerfile.pl

@@ -27,9 +27,11 @@ use C4::Context;
 use C4::Search;
 use C4::Output;
 
-=head1
+=head1 FUNCTIONS
 
-plugin_parameters : other parameters added when the plugin is called by the dopop function
+=head2 plugin_parameters
+
+Other parameters added when the plugin is called by the dopop function
 
 =cut
 

cataloguing/value_builder/normarc_field_008.pl

@@ -25,9 +25,11 @@ use C4::Context;
 use C4::Search;
 use C4::Output;
 
-=head1
+=head1 FUNCTIONS
 
-plugin_parameters : other parameters added when the plugin is called by the dopop function
+=head2 plugin_parameters
+
+Other parameters added when the plugin is called by the dopop function
 
 =cut
 

cataloguing/value_builder/unimarc_field_123i.pl

@@ -27,11 +27,14 @@ use C4::Context;
 use C4::Search;
 use C4::Output;
 
-=head1
+=head1 FUNCTIONS
 
-plugin_parameters : other parameters added when the plugin is called by the dopop function
+=head2 plugin_parameters
+
+Other parameters added when the plugin is called by the dopop function
 
 =cut
+
 sub plugin_parameters {
 my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
 return "";

cataloguing/value_builder/unimarc_field_123j.pl

@@ -27,9 +27,11 @@ use C4::Context;
 use C4::Search;
 use C4::Output;
 
-=head1
+=head1 FUNCTIONS
 
-plugin_parameters : other parameters added when the plugin is called by the dopop function
+=head2 plugin_parameters
+
+Other parameters added when the plugin is called by the dopop function
 
 =cut
 

cataloguing/value_builder/unimarc_field_124.pl

@@ -27,11 +27,14 @@ use C4::Context;
 use C4::Search;
 use C4::Output;
 
-=head1
+=head1 FUNCTIONS
 
-plugin_parameters : other parameters added when the plugin is called by the dopop function
+=head2 plugin_parameters
+
+Other parameters added when the plugin is called by the dopop function
 
 =cut
+
 sub plugin_parameters {
 my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
 return "";

cataloguing/value_builder/unimarc_field_124a.pl

@@ -27,11 +27,14 @@ use C4::Context;
 use C4::Search;
 use C4::Output;
 
-=head1
+=head1 FUNCTIONS
 
-plugin_parameters : other parameters added when the plugin is called by the dopop function
+=head2 plugin_parameters
+
+Other parameters added when the plugin is called by the dopop function
 
 =cut
+
 sub plugin_parameters {
 my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
 return "";
@@ -68,14 +71,16 @@ my ($input) = @_;
 
 	my $dbh = C4::Context->dbh;
 
-my ($template, $loggedinuser, $cookie)
-    = get_template_and_user({template_name => "cataloguing/value_builder/unimarc_field_124a.tt",
-			     query => $input,
-			     type => "intranet",
-			     authnotrequired => 0,
-			     flagsrequired => {editcatalogue => '*'},
-			     debug => 1,
-			     });
+    my ($template, $loggedinuser, $cookie) = get_template_and_user(
+        {
+            template_name   => "cataloguing/value_builder/unimarc_field_124a.tt",
+            query           => $input,
+            type            => "intranet",
+            authnotrequired => 0,
+            flagsrequired   => { editcatalogue => '*' },
+            debug           => 1,
+        }
+    );
 	my $f1 = substr($result,0,1);
 	$template->param(index => $index,
 			 "f1$f1" => 1);

cataloguing/value_builder/unimarc_field_124g.pl

@@ -27,11 +27,14 @@ use C4::Context;
 use C4::Search;
 use C4::Output;
 
-=head1
+=head1 FUNCTIONS
 
-plugin_parameters : other parameters added when the plugin is called by the dopop function
+=head2 plugin_parameters
+
+Other parameters added when the plugin is called by the dopop function
 
 =cut
+
 sub plugin_parameters {
 my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
 return "";

cataloguing/value_builder/unimarc_field_126.pl

@@ -27,11 +27,14 @@ use C4::Context;
 use C4::Search;
 use C4::Output;
 
-=head1
+=head1 FUNCTIONS
 
-plugin_parameters : other parameters added when the plugin is called by the dopop function
+=head2 plugin_parameters
+
+Other parameters added when the plugin is called by the dopop function
 
 =cut
+
 sub plugin_parameters {
 my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
 return "";

cataloguing/value_builder/unimarc_field_127.pl

@@ -27,11 +27,14 @@ use C4::Context;
 use C4::Search;
 use C4::Output;
 
-=head1
+=head1 FUNCTIONS
 
-plugin_parameters : other parameters added when the plugin is called by the dopop function
+=head2 plugin_parameters
+
+Other parameters added when the plugin is called by the dopop function
 
 =cut
+
 sub plugin_parameters {
 my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
 return "";

cataloguing/value_builder/unimarc_field_128a.pl

@@ -27,11 +27,14 @@ use C4::Context;
 use C4::Search;
 use C4::Output;
 
-=head1
+=head1 FUNCTIONS
 
-plugin_parameters : other parameters added when the plugin is called by the dopop function
+=head2 plugin_parameters
+
+Other parameters added when the plugin is called by the dopop function
 
 =cut
+
 sub plugin_parameters {
 my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
 return "";

cataloguing/value_builder/unimarc_field_128c.pl

@@ -27,9 +27,11 @@ use C4::Context;
 use C4::Search;
 use C4::Output;
 
-=head1
+=head1 FUNCTIONS
 
-plugin_parameters : other parameters added when the plugin is called by the dopop function
+=head2 plugin_parameters
+
+Other parameters added when the plugin is called by the dopop function
 
 =cut
 

cataloguing/value_builder/unimarc_field_135a.pl

@@ -27,11 +27,14 @@ use C4::Context;
 use C4::Search;
 use C4::Output;
 
-=head1
+=head1 FUNCTIONS
 
-plugin_parameters : other parameters added when the plugin is called by the dopop function
+=head2 plugin_parameters
+
+Other parameters added when the plugin is called by the dopop function
 
 =cut
+
 sub plugin_parameters {
 my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
 return "";

cataloguing/value_builder/unimarc_field_140.pl

@@ -27,11 +27,14 @@ use C4::Context;
 use C4::Search;
 use C4::Output;
 
-=head1
+=head1 FUNCTIONS
 
-plugin_parameters : other parameters added when the plugin is called by the dopop function
+=head2 plugin_parameters
+
+Other parameters added when the plugin is called by the dopop function
 
 =cut
+
 sub plugin_parameters {
 my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
 return "";

cataloguing/value_builder/unimarc_field_210c.pl

@@ -32,19 +32,22 @@ use C4::Koha;
 
 ###TODO To rewrite in order to use SearchAuthorities
 
-=head1
+=head1 FUNCTIONS
 
-plugin_parameters : other parameters added when the plugin is called by the dopop function
+=head2 plugin_parameters
+
+Other parameters added when the plugin is called by the dopop function
 
 =cut
+
 sub plugin_parameters {
 my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
 return "";
 }
 
-=head1
+=head2 plugin_javascript
 
-plugin_javascript : the javascript function called when the user enters the subfield.
+The javascript function called when the user enters the subfield.
 contain 3 javascript functions :
 * one called when the field is entered (OnFocus). Named FocusXXX
 * one called when the field is leaved (onBlur). Named BlurXXX
@@ -56,6 +59,7 @@ returns :
 the 3 scripts are inserted after the <input> in the html code
 
 =cut
+
 sub plugin_javascript {
 my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
 my $function_name= $field_number;
@@ -86,9 +90,9 @@ function Clic$function_name(subfield_managed) {
 return ($function_name,$res);
 }
 
-=head1
+=head2 plugin
 
-plugin : the true value_builded. The screen that is open in the popup window.
+The true value_builded. The screen that is open in the popup window.
 
 =cut
 

cataloguing/value_builder/unimarc_leader.pl

@@ -27,9 +27,11 @@ use C4::Context;
 use C4::Search;
 use C4::Output;
 
-=head1
+=head1 FUNCTIONS
 
-plugin_parameters : other parameters added when the plugin is called by the dopop function
+=head2 plugin_parameters
+
+Other parameters added when the plugin is called by the dopop function
 
 =cut
 

members/mancredit.pl

@@ -60,7 +60,7 @@ if ($add){
         print $input->redirect("/cgi-bin/koha/members/boraccount.pl?borrowernumber=$borrowernumber");
     }
 } else {
-	my ($template, $loggedinuser, $cookie) = get_template_and_user(
+    my ($template, $loggedinuser, $cookie) = get_template_and_user(
         {
             template_name   => "members/mancredit.tt",
             query           => $input,

members/statistics.pl

@@ -17,7 +17,9 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 =head1 members/statistics.pl
+
   Generate statistic issues for a member
+
 =cut
 
 use Modern::Perl;
@@ -112,9 +114,12 @@ output_html_with_http_headers $input, $cookie, $template->output;
 =head1 FUNCTIONS
 
 =head2 add_actual_state
+
   Add a 'count_actual_state' key in all hashes
   count_actual_state = count_precedent_state - count_total_issues_returned_today + count_total_issues_today
+
 =cut
+
 sub add_actual_state {
     my ( $array ) = @_;
     for my $hash ( @$array ) {
@@ -123,6 +128,7 @@ sub add_actual_state {
 }
 
 =head2 build_array
+
   Build a new array containing values of hashes.
   It used by template whitch display silly values.
   ex:
@@ -151,6 +157,7 @@ sub add_actual_state {
     ];
 
 =cut
+
 sub build_array {
     my ( $array ) = @_;
     my ( @r, $total );
@@ -173,6 +180,7 @@ sub build_array {
 }
 
 =head2 merge
+
   Merge hashes with the same statistic column names into one
   param: array, a arrayref of arrayrefs
   ex:
@@ -202,6 +210,7 @@ sub build_array {
    ];
 
 =cut
+
 sub merge {
     my @array = @_;
     my @r;

reports/acquisitions_stats.pl

@@ -1,6 +1,5 @@
 #!/usr/bin/perl
 
-
 # Copyright 2000-2002 Katipo Communications
 #
 # This file is part of Koha.
@@ -18,8 +17,6 @@
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
-# test comment
-
 use Modern::Perl;
 
 use C4::Auth;
@@ -35,11 +32,11 @@ use C4::Biblio;
 
 =head1 NAME
 
-plugin that shows a stats on borrowers
+reports/acquisitions_stats.pl
 
 =head1 DESCRIPTION
 
-=over 2
+Plugin that shows a stats on borrowers
 
 =cut
 

reports/borrowers_out.pl

@@ -32,11 +32,11 @@ use C4::Dates qw/format_date_in_iso/;
 
 =head1 NAME
 
-plugin that shows a stats on borrowers
+reports/borrowers_out.pl
 
 =head1 DESCRIPTION
 
-=over 2
+Plugin that shows a stats on borrowers
 
 =cut
 

reports/issues_stats.pl

@@ -1,6 +1,5 @@
 #!/usr/bin/perl
 
-
 # Copyright 2000-2002 Katipo Communications
 #
 # This file is part of Koha.
@@ -37,11 +36,11 @@ use C4::Members;
 
 =head1 NAME
 
-plugin that shows circulation stats
+reports/issues_stats.pl
 
 =head1 DESCRIPTION
 
-=over 2
+Plugin that shows circulation stats
 
 =cut
 

serials/acqui-search-result.pl

@@ -26,6 +26,7 @@
 acqui-search-result.pl
 
 =head1 DESCRIPTION
+
  TODO
 
 =head1 PARAMETERS

virtualshelves/addbybiblionumber.pl

@@ -23,7 +23,7 @@
 
 =head1 NAME
 
-    addbybiblionumber.pl
+addbybiblionumber.pl
 
 =head1 DESCRIPTION