gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 12768: (QA follow-up) Use specific account offset types for Processing Fee and Lost Item 

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Kyle M Hall 2017-10-23 11:01:25 -04:00 committed by Jonathan Druart
parent 276b0e2587
commit 1ea5f9c82a
4 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
C4/Accounts.pm
View File

@ -230,10 +230,15 @@ sub manualinvoice {
}
)->store();
my $offset_type =
$type eq 'L' ? 'Lost Item'
: $type eq 'PF' ? 'Processing Fee'
: 'Manual Debit';
my $account_offset = Koha::Account::Offset->new(
{
debit_id => $accountline->id,
type => 'Manual Debit',
type => $offset_type,
amount => $amount,
}
)->store();

1
installer/data/mysql/account_offset_types.sql
View File

@ -2,6 +2,7 @@ INSERT INTO account_offset_types ( type ) VALUES
('Writeoff'),
('Payment'),
('Lost Item'),
('Processing Fee'),
('Manual Debit'),
('Reverse Payment'),
('Forgiven'),

1
installer/data/mysql/atomicupdate/processing_fee.sql Normal file
View File

@ -0,0 +1 @@
INSERT IGNORE INTO account_offset_types ( type ) VALUES ( 'Processing Fee' );

9
t/db_dependent/Circulation/Chargelostitem.t
View File

@ -2,7 +2,7 @@
use Modern::Perl;
use Test::More tests => 4;
use Test::More tests => 6;
use Test::MockModule;
use t::lib::Mocks;
use t::lib::TestBuilder;
@ -62,6 +62,7 @@ AddIssue($borrower, '0101');
AddIssue($borrower, '0203');
# Begin tests...
Koha::Account::Offsets->delete();
my $issue = Koha::Checkouts->search( { borrowernumber => $borrowernumber } )->next()->unblessed();
C4::Accounts::chargelostitem( $borrowernumber, $issue->{itemnumber}, '1.00');
@ -70,3 +71,9 @@ my $accountline = Koha::Account::Lines->search( { borrowernumber => $borrowernum
is( int($accountline->amount), $itemtype->{processfee}, "The accountline amount should be precessfee value " );
is( $accountline->itemnumber, $itemnumber1, "The accountline itemnumber should the linked with barcode '0101'" );
is( $accountline->note, C4::Context->preference("ProcessingFeeNote"), "The accountline description should be 'test'" );
my $lost_ao = Koha::Account::Offsets->single( { type => 'Lost Item' } );
ok( $lost_ao, 'Account offset of type "Lost Item" created' );
my $processing_fee_ao = Koha::Account::Offsets->single( { type => 'Processing Fee' } );
ok( $processing_fee_ao, 'Account offset of type "Processing Fee" created' );