gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 16035: MARC default bibliographic framework Export fix 

This patch makes sure that, if there is no framework code,
     $frameworkcode is set to 'default'. This fixes the format issue.
     Then, if $frameworkcode = default, an empty string (rather than
     null) is passed to the ExportFramework method, as the framework
     code in the DB for default codes is "".

To test:
1) Go to Admin -> MARC Bibliographic framework
2) Try to export default framework in all formats, notice the file is
only exported as .ods and is an empty file. Notice warns in intranet
error log.
3) Apply patch and refresh page
4) Confirm exporting default framework works in all formats and
spreadsheet has data
5) Notice warns in error log are gone
6) Confirm export still works for other frameworks

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 705097f938)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
This commit is contained in:
Aleisha Amohia 2016-08-24 21:24:45 +00:00 committed by Frédéric Demians
parent 4f5d1faef5
commit 1de610bb63
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
admin/import_export_framework.pl
View File

@ -46,14 +46,18 @@ unless ($authenticated) {
exit 0;
}
my $frameworkcode = $input->param('frameworkcode') || '';
my $frameworkcode = $input->param('frameworkcode') || 'default';
my $action = $input->param('action') || 'export';
## Exporting
if ($action eq 'export' && $input->request_method() eq 'GET') {
my $strXml = '';
my $format = $input->param('type_export_' . $frameworkcode);
ExportFramework($frameworkcode, \$strXml, $format);
if ($frameworkcode == 'default') {
ExportFramework('', \$strXml, $format);
} else {
ExportFramework($frameworkcode, \$strXml, $format);
}
if ($format eq 'csv') {
# CSV file