gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 3492: (follow-up) Remove last reservefee references 

Sponsored-by: OpenFifth <https://openfifth.co.uk>
Signed-off-by: Jackie Usher <jackie.usher@westsussex.gov.uk>
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Martin Renvoize 2025-09-11 07:27:11 +01:00 committed by Lucas Gass
parent f1b20b645c
commit 1c893cc019
No known key found for this signature in database
GPG Key ID: 60B447398B0D36CA
4 changed files with 3 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
installer/data/mysql/en/optional/patron_categories.yml
View File

@ -54,7 +54,6 @@ tables:
dateofbirthrequired: 18
enrolmentfee: '0.000000'
overduenoticerequired: 1
reservefee: '0.000000'
category_type: 'A'
can_be_guarantee: 0
@ -65,7 +64,6 @@ tables:
dateofbirthrequired: 18
enrolmentfee: '0.000000'
overduenoticerequired: 1
reservefee: '0.000000'
category_type: 'A'
can_be_guarantee: 0
@ -76,7 +74,6 @@ tables:
dateofbirthrequired: 18
enrolmentfee: '0.000000'
overduenoticerequired: 1
reservefee: '0.000000'
category_type: 'A'
can_be_guarantee: 0
@ -88,7 +85,6 @@ tables:
dateofbirthrequired: 5
enrolmentfee: '0.000000'
overduenoticerequired: 1
reservefee: '0.000000'
category_type: 'C'
can_be_guarantee: 1
@ -99,7 +95,6 @@ tables:
dateofbirthrequired: 5
enrolmentfee: '0.000000'
overduenoticerequired: 1
reservefee: '0.000000'
category_type: 'C'
can_be_guarantee: 1
@ -110,7 +105,6 @@ tables:
dateofbirthrequired: 5
enrolmentfee: '0.000000'
overduenoticerequired: 1
reservefee: '0.000000'
category_type: 'C'
can_be_guarantee: 1
@ -122,7 +116,6 @@ tables:
dateofbirthrequired: 18
enrolmentfee: '0.000000'
overduenoticerequired: 0
reservefee: '0.000000'
category_type: 'P'
can_be_guarantee: 1
@ -133,7 +126,6 @@ tables:
dateofbirthrequired: 5
enrolmentfee: '0.000000'
overduenoticerequired: 1
reservefee: '0.000000'
category_type: 'P'
can_be_guarantee: 1
@ -145,7 +137,6 @@ tables:
dateofbirthrequired: 18
enrolmentfee: '0.000000'
overduenoticerequired: 1
reservefee: '0.000000'
category_type: 'I'
can_be_guarantee: 0
@ -156,7 +147,6 @@ tables:
dateofbirthrequired: 18
enrolmentfee: '0.000000'
overduenoticerequired: 1
reservefee: '0.000000'
category_type: 'I'
can_be_guarantee: 0
@ -167,7 +157,6 @@ tables:
dateofbirthrequired: 18
enrolmentfee: '0.000000'
overduenoticerequired: 1
reservefee: '0.000000'
category_type: 'I'
can_be_guarantee: 0
@ -179,6 +168,5 @@ tables:
dateofbirthrequired: 18
enrolmentfee: '0.000000'
overduenoticerequired: 0
reservefee: '0.000000'
category_type: 'S'
can_be_guarantee: 0

7
t/db_dependent/Circulation/GetHardDueDate.t
View File

@ -82,19 +82,18 @@ my $samplecat = {
dateofbirthrequired => undef,
enrolmentfee => undef,
overduenoticerequired => undef,
reservefee => undef,
hidelostitems => 0,
category_type => 'A',
};
my $query =
"INSERT INTO categories (categorycode,description,enrolmentperiod,enrolmentperioddate,dateofbirthrequired,enrolmentfee,overduenoticerequired ,reservefee ,hidelostitems ,category_type) VALUES( ?,?,?,?,?,?,?,?,?,?)";
"INSERT INTO categories (categorycode,description,enrolmentperiod,enrolmentperioddate,dateofbirthrequired,enrolmentfee,overduenoticerequired,hidelostitems,category_type) VALUES(?,?,?,?,?,?,?,?,?)";
$dbh->do(
$query, {},
$samplecat->{categorycode}, $samplecat->{description},
$samplecat->{enrolmentperiod}, $samplecat->{enrolmentperioddate},
$samplecat->{dateofbirthrequired}, $samplecat->{enrolmentfee},
$samplecat->{overduenoticerequired}, $samplecat->{reservefee},
$samplecat->{hidelostitems}, $samplecat->{category_type}
$samplecat->{overduenoticerequired}, $samplecat->{hidelostitems},
$samplecat->{category_type}
);
my $builder = t::lib::TestBuilder->new;

1
t/db_dependent/Koha/Holds.t
View File

@ -486,7 +486,6 @@ subtest 'cancel' => sub {
my $patron_category = $builder->build_object(
{
class => 'Koha::Patron::Categories',
value => { reservefee => 0 }
}
);
my $patron = $builder->build_object(

1
t/lib/TestBuilder.pm
View File

@ -655,7 +655,6 @@ sub _gen_default_values {
},
Category => {
enrolmentfee => 0,
reservefee => 0,
# Not X, used for statistics
category_type => sub { return [qw( A C S I P )]->[ int( rand(5) ) ] },