Bug 21211: Add patron toolbar to suggestions, discharges and ill requests tabs

When paging through the patron account in staff, using the tabs on
the right, you notice that some pages are missing the patron toolbar
on top and that the headings, where they exist, vary in size.

This patch adds the patron toolbar to 3 more tabs and changes headings
to h1 to be consistent with older tabs. It has also been suggested on
another tab that this is preferrable for screen readers.

Note: Modification log was left out for now, as this is also used in tools.

To test:
- Activate ILL (ILLModule pref)
- Activate discharges (UseDischarge pref)
- Go to any patron account, tab through the tabs...
- Verify that discharge, purchase suggestions and ill requests are
  missing the toolbar
- Apply patch
- Verify that the toolbar now appears on these pages and works
  correctly
- Also veriy that the headings are now consistently h1 on all pages

Signed-off-by: David Roberts <david@koha-ptfs.co.uk>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
This commit is contained in:
Katrin Fischer 2020-04-14 13:14:37 +00:00 committed by Joy Nelson
parent a934499b8c
commit 1b9fd03f17
5 changed files with 12 additions and 6 deletions

View File

@ -23,11 +23,13 @@
<div class="col-sm-10 col-sm-push-2">
<main>
<h3>Discharge</h3>
[% INCLUDE 'members-toolbar.inc' %]
<h1>Discharge</h1>
[% FOR message IN messages %]
<div class="dialog [% message.type | html %]">
[% IF message.code == "unable_to_generate_pdf" %]
An error occurs when generating the pdf file.
An error occurs when generating the PDF file.
Please contact the administrator to resolve this problem.
[% END %]
</div>

View File

@ -28,7 +28,7 @@
[% INCLUDE 'members-toolbar.inc' %]
<!-- Title -->
<h3>Housebound details for [% INCLUDE 'patron-title.inc' %]</h3>
<h1>Housebound details for [% INCLUDE 'patron-title.inc' %]</h1>
[% FOR m IN messages %]
<div class="dialog [% m.type | html %]">

View File

@ -27,7 +27,8 @@
<div class="row">
<div class="col-sm-10 col-sm-push-2">
<main>
<h2>ILL requests history</h2>
[% INCLUDE 'members-toolbar.inc' %]
<h1>ILL requests history</h1>
[% INCLUDE 'ill-list-table.inc' %]
</main>
</div> <!-- .col-sm-10.col-sm-push-2 -->
@ -40,6 +41,8 @@
</div> <!-- .row -->
[% MACRO jsinclude BLOCK %]
[% INCLUDE 'str/members-menu.inc' %]
[% Asset.js("js/members-menu.js") | $raw %]
[% INCLUDE 'datatables.inc' %]
[% INCLUDE 'columns_settings.inc' %]
[% INCLUDE 'calendar.inc' %]

View File

@ -24,7 +24,8 @@
<div class="col-sm-10 col-sm-push-2">
<main>
<h2>Purchase suggestions</h2>
[% INCLUDE 'members-toolbar.inc' %]
<h1>Purchase suggestions</h1>
<div id="toolbar" class="btn-toolbar">
<a class="btn btn-default" id="newsuggestion" href="/cgi-bin/koha/suggestion/suggestion.pl?op=add&amp;suggestedby=[% patron.borrowernumber | html %]&amp;redirect=purchase_suggestions&amp;borrowernumber=[% patron.borrowernumber | html %]"><i class="fa fa-plus"></i> New purchase suggestion</a>

View File

@ -30,7 +30,7 @@
[% INCLUDE 'members-toolbar.inc' %]
<h3>Statistics for [% INCLUDE 'patron-title.inc' %]</h3>
<h1>Statistics for [% INCLUDE 'patron-title.inc' %]</h1>
[% IF ( datas.size ) %]
<table id="statistics">
<thead>