From 198f9d77385c8a33896f8ccdbc176e5325307673 Mon Sep 17 00:00:00 2001
From: Alexander Blanchard <alexander.blanchard@openfifth.co.uk>
Date: Mon, 7 Apr 2025 11:33:02 +0000
Subject: [PATCH] Bug 39490: Table Columns Missing Headings

An accessibility audit highlighted that the purchase suggestions
and search history tables in the 'My Account' section do not
have headings in the tickbox column. The report suggests headings
should be added to support those using screen readers.

To Test:
1) In the opac, navigate to 'Your Account'
2) Navigate to 'Purchase Suggestions'
3) Add a purchase suggestion if you currently have none
4) Note that the left column does not have a heading and you cannot tab to it
5) Navigate to 'Search History'
6) Note, you must have searched the catalogue at least once for this table to display
7) Note that the left column does not have a heading and you cannot tab to it
8) Apply the patch
9) Repeat the steps above
10) Note that the tables now have a tooltip with information relevant to the column
11) Note that this column heading can now be tabbed to

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 .../opac-tmpl/bootstrap/en/modules/opac-search-history.tt   | 4 +++-
 .../opac-tmpl/bootstrap/en/modules/opac-suggestions.tt      | 6 +++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
index 5e14205159..ffd3c69649 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
@@ -198,7 +198,9 @@
                     <caption class="sr-only">Current session</caption>
                     <thead>
                         <tr>
-                            <th></th>
+                            <th>
+                                <i data-bs-toggle="tooltip" title="Check the boxes in this column to select searches for deletion" data-bs-placement="right" class="fa fa-info-circle" tabindex="0"></i>
+                            </th>
                             <th>Date</th>
                             <th>Search</th>
                             <th>Results</th>
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
index 1e662b76a9..037d725c0a 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
@@ -415,7 +415,11 @@
                                         <caption class="sr-only">Your purchase suggestions</caption>
                                         <thead>
                                             <tr>
-                                                [% IF ( loggedinusername ) %]<th>&nbsp;</th>[% END %]
+                                                [% IF ( loggedinusername ) %]
+                                                    <th>
+                                                        <i data-bs-toggle="tooltip" title="Check the boxes in this column to select purchase suggestions for deletion" data-bs-placement="right" class="fa fa-info-circle" tabindex="0"></i>
+                                                    </th>
+                                                [% END %]
                                                 <th class="all">Summary</th>
                                                 <th>Suggested on</th>
                                                 <th>Note</th>