gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 24683: Optimize loop in ItemsAnyAvailableAndNotRestricted 

Add cut-off shortcut (return from inside the loop) when first
"Any Available And Not Restricted" item found, because one is
enough for "Any".

Testing: no change visible for code behavior/results,
it is just faster because won't loop over the whole set.

Signed-off-by: Agustin Moyano <agustinmoyano@theke.io>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 720b69780c)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Andrew Nugged 2020-07-17 14:59:19 +03:00 committed by Lucas Gass
parent a831c288da
commit 13c5c4d85e
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
C4/Reserves.pm
View File

@ -1322,8 +1322,6 @@ sub ItemsAnyAvailableAndNotRestricted {
my @items = Koha::Items->search( { biblionumber => $param->{biblionumber} } );
my $any_available = 0;
foreach my $i (@items) {
my $reserves_control_branch =
GetReservesControlBranch( $i->unblessed(), $param->{patron}->unblessed );
@ -1331,7 +1329,8 @@ sub ItemsAnyAvailableAndNotRestricted {
C4::Circulation::GetBranchItemRule( $reserves_control_branch, $i->itype );
my $item_library = Koha::Libraries->find( { branchcode => $i->homebranch } );
$any_available = 1
# we can return (end the loop) when first one found:
return 1
unless $i->itemlost
|| $i->notforloan > 0
|| $i->withdrawn
@ -1344,7 +1343,7 @@ sub ItemsAnyAvailableAndNotRestricted {
|| $branchitemrule->{holdallowed} == 3 && ! $item_library->validate_hold_sibling( { branchcode => $param->{patron}->branchcode } );
}
return $any_available;
return 0;
}
=head2 AlterPriority