Bug 25262: [19.05.x] Do not truncate MANUAL_INV in dropdown
There is an issue in that historic values will still be truncated, but recent values are not. I feel the cash register report should reflect recent transactions over historic, and the historic are a data cleanup issue To test: 1 - Add a MANUAL_INV value with more than 5 characters 'INCREDIBLE_HULK' 2 - Add a manual invoice to a patron's acccount using this value 3 - Note the full code displays in patrons account 4 - Browse to Reports->Cash register 5 - Search for today's date, the value you createed, and all libraries 6 - No results returned 7 - Apply patch 8 - Repeat 5 9 - The transaction shows Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
parent
4c44691ed9
commit
12bf0c91d1
|
|
@ -121,11 +121,10 @@
|
|||
[% END %]
|
||||
|
||||
[% FOREACH manualinv IN manualinv_types %]
|
||||
[% value_manualinv = manualinv.authorised_value|truncate(5, '') %]
|
||||
[% IF transaction_type == value_manualinv %]
|
||||
<option value="[% value_manualinv | html %]" selected="selected">[% manualinv.authorised_value | html %]</option>
|
||||
[% IF transaction_type == manualinv.authorised_value %]
|
||||
<option value="[% manualinv.authorised_value | html %]" selected="selected">[% manualinv.authorised_value | html %]</option>
|
||||
[% ELSE %]
|
||||
<option value="[% value_manualinv | html %]">[% manualinv.authorised_value | html %]</option>
|
||||
<option value="[% manualinv.authorised_value | html %]">[% manualinv.authorised_value | html %]</option>
|
||||
[% END %]
|
||||
[% END %]
|
||||
</select>
|
||||
|
|
|
|||
Loading…
Reference in New Issue