diff --git a/C4/Reserves.pm b/C4/Reserves.pm index 78e9a5b890..bba4933922 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -2171,8 +2171,11 @@ sub ReserveSlip { # return unless ( C4::Context->boolean_preference('printreserveslips') ); - my $reserve = GetReserveInfo($borrowernumber,$biblionumber ) - or return; + my $reserve_id = GetReserveId({ + biblionumber => $biblionumber, + borrowernumber => $borrowernumber + }) or return; + my $reserve = GetReserveInfo($reserve_id) or return; return C4::Letters::GetPreparedLetter ( module => 'circulation', diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t index ea60d54133..ad50619d31 100755 --- a/t/db_dependent/Reserves.t +++ b/t/db_dependent/Reserves.t @@ -2,7 +2,7 @@ use Modern::Perl; -use Test::More tests => 16; +use Test::More tests => 17; use MARC::Record; use DateTime::Duration; @@ -263,4 +263,7 @@ is(exists $messages->{ResFound}?1:0, 1, 'AddReturn considers future reserve with # End of tests for bug 9761 (ConfirmFutureHolds) +my $letter = ReserveSlip('CPL', $requesters{'CPL'}, $bibnum); +ok(defined($letter), 'can successfully generate hold slip (bug 10949)'); + $dbh->rollback;