From 1013d5b74eca448ccd2fa059a6144d0691e3385b Mon Sep 17 00:00:00 2001
From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Date: Tue, 24 Dec 2024 10:42:21 +0000
Subject: [PATCH] Bug 38782: Remove concat in background process

The ud_provider->{report_type} is only defined on ->harvest_sushi, meaning it'll never be defined here.
We don't need this anyway. The filename should be the filename of the file being manually uploaded. We only need this concat logic for COUNTER files being generated by Koha following a SUSHI harvest, and that works.
This also gets rid of a warning when running the tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 0231911c988f2f14d05a1aff97221f40ca4d90fa)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: wainuiwitikapark <wainuiwitikapark@catalyst.net.nz>
---
 Koha/BackgroundJob/ErmSushiHarvester.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Koha/BackgroundJob/ErmSushiHarvester.pm b/Koha/BackgroundJob/ErmSushiHarvester.pm
index 5dadc0b60f..da4721952b 100644
--- a/Koha/BackgroundJob/ErmSushiHarvester.pm
+++ b/Koha/BackgroundJob/ErmSushiHarvester.pm
@@ -92,7 +92,7 @@ sub process {
                     usage_data_provider_id => $ud_provider->erm_usage_data_provider_id,
                     file_content           => $args->{file_content},
                     date_uploaded          => POSIX::strftime( "%Y%m%d%H%M%S", localtime ),
-                    filename               => $ud_provider->name . "_" . $ud_provider->{report_type},
+                    filename               => $ud_provider->name,
                 }
             ]
         );