gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 15415: Warn when creating a new print profile 

As per Jonathan's comment in Comment 3, I've put that line of code in an
if statement that will only call the get_attr method if we are editing
an existing profile (therefore the profile id will exist).

To test:
1) Go to Tools -> Patron Card Creator -> New printer profile
2) Notice warn
3) Apply patch
4) Refresh page
5) Confirm warn is gone and page still works as expected

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 47e80e899a)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
This commit is contained in:
Aleisha Amohia 2016-12-02 03:04:07 +00:00 committed by Katrin Fischer
parent 9456d9e3f0
commit 0e8569583f
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
patroncards/edit-profile.pl
View File

@ -88,7 +88,9 @@ foreach my $unit (@$units) {
}
}
$template->param(profile_id => $profile->get_attr('profile_id')) if $profile->get_attr('profile_id') > 0;
if ($profile_id) { # if new layout, there will be no profile id, so shouldn't look for it
$template->param(profile_id => $profile->get_attr('profile_id')) if $profile->get_attr('profile_id') > 0;
}
$template->param(
label_template => $label_template[0]->{'template_code'} || '',