gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 41024: Unify spelling of BorrowersLog, keep plural form 

The singular form is wrong and only exists in textual context.
This is a result of git grep | xargs sed.

Test plan:
Read the patch.
git grep BorrowerLog

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Aleisha Amohia <aleisha@catalyst.net.nz>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 4a267d0e9b)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
(cherry picked from commit f59d8c46e3)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Marcel de Rooy 2025-10-15 13:29:54 +02:00 committed by Fridolin Somers
parent 2a2d7eb0d2
commit 0df2d94dfa
No known key found for this signature in database
GPG Key ID: 9A8E73E2A8B96537
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
misc/release_notes/release_notes_19_11_00.html
View File

@ -1366,7 +1366,7 @@ have already been fixed in maintainance releases)</p>
<p><strong>Sponsored by</strong> <em>Goethe-Institut</em></p></li>
<li><p><a href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939">[21939]</a> Permission for holds history tab is too strict</p></li>
<li><a href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741">[22741]</a> Koha::Patron->store must not log updated_on changes (random failure of test BorrowerLogs and TrackLastPatronActivity)</li>
<li><a href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741">[22741]</a> Koha::Patron->store must not log updated_on changes (random failure of test BorrowersLog and TrackLastPatronActivity)</li>
<li><a href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22910">[22910]</a> Unique attributes should not be copied when duplicating a patron</li>
<li><a href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22944">[22944]</a> avoid AnonymousPatron in search_patrons_to_anonymise</li>
<li><a href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077">[23077]</a> Can't import patrons without cardnumber</li>

2
misc/release_notes/release_notes_19_11_00.md
View File

@ -1104,7 +1104,7 @@ have already been fixed in maintainance releases)
**Sponsored by** *Goethe-Institut*
- [[21939]](http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939) Permission for holds history tab is too strict
- [[22741]](http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741) Koha::Patron->store must not log updated_on changes (random failure of test BorrowerLogs and TrackLastPatronActivity)
- [[22741]](http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741) Koha::Patron->store must not log updated_on changes (random failure of test BorrowersLog and TrackLastPatronActivity)
- [[22910]](http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22910) Unique attributes should not be copied when duplicating a patron
- [[22944]](http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22944) avoid AnonymousPatron in search_patrons_to_anonymise
- [[23077]](http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077) Can't import patrons without cardnumber

14
t/db_dependent/Koha/Patrons.t
View File

@ -408,7 +408,7 @@ subtest 'renew_account' => sub {
my $retrieved_expiry_date = Koha::Patrons->find( $patron->{borrowernumber} )->dateexpiry;
is( dt_from_string($retrieved_expiry_date), $a_year_later_minus_a_month, "$a_month_ago + 12 months must be $a_year_later_minus_a_month" );
my $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'RENEW', object => $retrieved_patron->borrowernumber } )->count;
is( $number_of_logs, 1, 'With BorrowerLogs, Koha::Patron->renew_account should have logged' );
is( $number_of_logs, 1, 'With BorrowersLog, Koha::Patron->renew_account should have logged' );
t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'now' );
t::lib::Mocks::mock_preference( 'BorrowersLog', 0 );
@ -419,7 +419,7 @@ subtest 'renew_account' => sub {
$retrieved_expiry_date = $retrieved_patron->dateexpiry;
is( dt_from_string($retrieved_expiry_date), $a_year_later, "today + 12 months must be $a_year_later" );
$number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'RENEW', object => $retrieved_patron->borrowernumber } )->count;
is( $number_of_logs, 1, 'Without BorrowerLogs, Koha::Patron->renew_account should not have logged' );
is( $number_of_logs, 1, 'Without BorrowersLog, Koha::Patron->renew_account should not have logged' );
t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'combination' );
$expiry_date = $retrieved_patron_2->renew_account;
@ -508,7 +508,7 @@ subtest "delete" => sub {
is( Koha::Patron::Modifications->search( { borrowernumber => $patron->borrowernumber } )->count, 0, q|Koha::Patron->delete should have deleted patron's modifications| );
my $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'DELETE', object => $patron->borrowernumber } )->count;
is( $number_of_logs, 1, 'With BorrowerLogs, Koha::Patron->delete should have logged' );
is( $number_of_logs, 1, 'With BorrowersLog, Koha::Patron->delete should have logged' );
# Test deletion with designated fallback owner
my $designated_owner = $builder->build_object({ class => 'Koha::Patrons' });
@ -1771,12 +1771,12 @@ subtest 'BorrowersLog tests' => sub {
my $log_info = from_json( $logs[0]->info );
is( $log_info->{cardnumber}->{after}, 'TESTCARDNUMBER', 'Got correct new cardnumber' );
is( $log_info->{cardnumber}->{before}, $cardnumber, 'Got correct old cardnumber' );
is( scalar @logs, 1, 'With BorrowerLogs, one detailed MODIFY action should be logged for the modification.' );
is( scalar @logs, 1, 'With BorrowersLog, one detailed MODIFY action should be logged for the modification.' );
t::lib::Mocks::mock_preference( 'TrackLastPatronActivityTriggers', 'connection' );
$patron->update_lastseen('connection');
@logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'MODIFY', object => $patron->borrowernumber } );
is( scalar @logs, 1, 'With BorrowerLogs and TrackLastPatronActivityTriggers we should not spam the logs');
is( scalar @logs, 1, 'With BorrowersLog and TrackLastPatronActivityTriggers we should not spam the logs');
Koha::ActionLogs->search()->delete();
$patron->get_from_storage();
@ -2156,7 +2156,7 @@ subtest '->set_password' => sub {
is( $patron->login_attempts, 0, 'Login attemps have been reset' );
my $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'CHANGE PASS', object => $patron->borrowernumber } )->count;
is( $number_of_logs, 0, 'Without BorrowerLogs, Koha::Patron->set_password doesn\'t log password changes' );
is( $number_of_logs, 0, 'Without BorrowersLog, Koha::Patron->set_password doesn\'t log password changes' );
# Enable logging password changes
t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
@ -2168,7 +2168,7 @@ subtest '->set_password' => sub {
object => $patron->borrowernumber
}
)->count;
is( $number_of_logs, 1, 'With BorrowerLogs, Koha::Patron->set_password does log password changes' );
is( $number_of_logs, 1, 'With BorrowersLog, Koha::Patron->set_password does log password changes' );
# add other action name
$patron->set_password( { password => 'abcd b2', action => 'RESET PASS' } );
$number_of_logs = $schema->resultset('ActionLog')->search(