From 0d08141eb148ea2b3f7a55b4810aa38897874fe2 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 17 Jul 2025 09:51:02 +0200 Subject: [PATCH] Bug 40429: Remove warnings from Koha/Patron/Modifications.t t/db_dependent/Koha/Patron/Modifications.t .. 1/7 DBIx::Class::Storage::DBI::insert(): Missing value for primary key column 'borrowernumber' on BorrowerModification - perhaps you forgot to set its 'is_auto_increme nt' attribute during add_columns()? Treating 'borrowernumber' implicitly as an autoinc, and attempting value retrieval at /kohadevbox/koha/Koha/Object.pm line 174 t/db_dependent/Koha/Patron/Modifications.t .. 5/7 DBIx::Class::Storage::DBI::insert(): Missing value for primary key column 'verification_token' on BorrowerModification - perhaps you forgot to set its 'is_auto_inc rement' attribute during add_columns()? Treating 'verification_token' implicitly as an autoinc, and attempting value retrieval at /kohadevbox/koha/Koha/Object.pm line 174 Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass (cherry picked from commit f851367cf4899fcbf9411268e1a0c478f36d1b62) Signed-off-by: Paul Derscheid (cherry picked from commit 0bd9f325c8948cd52e25063abdc110d77c4a7613) Signed-off-by: Fridolin Somers --- t/db_dependent/Koha/Patron/Modifications.t | 28 ++++++++++++++++------ 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/t/db_dependent/Koha/Patron/Modifications.t b/t/db_dependent/Koha/Patron/Modifications.t index 4e03a246bd..9a987a83e7 100755 --- a/t/db_dependent/Koha/Patron/Modifications.t +++ b/t/db_dependent/Koha/Patron/Modifications.t @@ -19,7 +19,8 @@ use Modern::Perl; use utf8; -use Test::More tests => 7; +use Test::More tests => 8; +use Test::NoWarnings; use Test::Exception; use t::lib::TestBuilder; @@ -49,9 +50,13 @@ subtest 'new() tests' => sub { Koha::Patron::Modifications->search->delete; + my $patron = $builder->build_object( { class => 'Koha::Patrons' } ); + # Create new pending modification Koha::Patron::Modification->new( - { verification_token => '1234567890', + { + borrowernumber => $patron->borrowernumber, + verification_token => '1234567890', changed_fields => 'surname,firstname', surname => 'Hall', firstname => 'Kyle' @@ -391,8 +396,11 @@ subtest 'dateofbirth tests' => sub { $schema->storage->txn_begin; # Cleaning the field - my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { dateofbirth => '1980-01-01', surname => 'a_surname' } } ); - my $patron_modification = Koha::Patron::Modification->new( { + my $patron = $builder->build_object( + { class => 'Koha::Patrons', value => { dateofbirth => '1980-01-01', surname => 'a_surname' } } ); + my $patron_modification = Koha::Patron::Modification->new( + { + verification_token => '1234567890', changed_fields => 'borrowernumber,dateofbirth', borrowernumber => $patron->borrowernumber, dateofbirth => undef @@ -406,7 +414,9 @@ subtest 'dateofbirth tests' => sub { Koha::Patron::Modifications->search({ borrowernumber => $patron->borrowernumber })->delete; # Adding a dateofbirth - $patron_modification = Koha::Patron::Modification->new( { + $patron_modification = Koha::Patron::Modification->new( + { + verification_token => '1234567890', changed_fields => 'borrowernumber,dateofbirth', borrowernumber => $patron->borrowernumber, dateofbirth => '1980-02-02' @@ -421,7 +431,9 @@ subtest 'dateofbirth tests' => sub { Koha::Patron::Modifications->search({ borrowernumber => $patron->borrowernumber })->delete; # Modifying a dateofbirth - $patron_modification = Koha::Patron::Modification->new( { + $patron_modification = Koha::Patron::Modification->new( + { + verification_token => '1234567890', changed_fields => 'borrowernumber,dateofbirth', borrowernumber => $patron->borrowernumber, dateofbirth => '1980-03-03', @@ -437,7 +449,9 @@ subtest 'dateofbirth tests' => sub { Koha::Patron::Modifications->search({ borrowernumber => $patron->borrowernumber })->delete; # Modifying something else - $patron_modification = Koha::Patron::Modification->new( { + $patron_modification = Koha::Patron::Modification->new( + { + verification_token => '1234567890', changed_fields => 'borrowernumber,surname', borrowernumber => $patron->borrowernumber, surname => 'another_surname',