Bug 36351: Add CSRF tokens to advanced cataloguing editor POST requests

The editor uses ajax post requests to SVC api.
Becuase these apis are XML based requests, they must be handled in the simplest way, by
embedding the token as a header

To test:
1 - Browse to Cataloguing->Advanced editor
2 - Fill out needed values and save
3 - 403 error
4 - Apply patch
5 - Reload and try agian, success!
6 - Edit and save again, success!

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Nick Clemens 2024-03-18 17:28:56 +00:00 committed by Katrin Fischer
parent 34a3c3b8f6
commit 0cbc99a373
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
3 changed files with 40 additions and 13 deletions

View File

@ -136,20 +136,19 @@ define( [ '/cgi-bin/koha/svc/cataloguing/framework?frameworkcode=&callback=defin
record = record.clone();
_removeBiblionumberFields( record );
$.ajax( {
type: 'POST',
url: '/cgi-bin/koha/svc/new_bib?frameworkcode=' + encodeURIComponent(frameworkcode),
data: record.toXML(),
contentType: 'text/xml'
} ).done( function( data ) {
var record = _fromXMLStruct( data );
if ( record.marcxml ) {
record.marcxml[0].frameworkcode = frameworkcode;
const client = APIClient.cataloguing;
client.catalog_bib.create({ frameworkcode, record }).then(
success => {
var record = _fromXMLStruct( data );
if ( record.marcxml ) {
record.marcxml[0].frameworkcode = frameworkcode;
}
callback( record );
},
error => {
callback( { error: _('Could not save record') } );
}
callback( record );
} ).fail( function( data ) {
callback( { error: _('Could not save record') } );
} );
);
},
SaveRecord: function( id, record, callback ) {

View File

@ -1,5 +1,6 @@
import ArticleRequestAPIClient from "./article-request-api-client.js";
import AVAPIClient from "./authorised-value-api-client.js";
import CataloguingAPIClient from "./cataloguing-api-client.js";
import CirculationAPIClient from "./circulation-api-client.js";
import ClubAPIClient from "./club-api-client.js";
import CoverImageAPIClient from "./cover-image-api-client.js";
@ -12,6 +13,7 @@ import TicketAPIClient from "./ticket-api-client.js";
export const APIClient = {
article_request: new ArticleRequestAPIClient(),
authorised_value: new AVAPIClient(),
cataloguing: new CataloguingAPIClient(),
circulation: new CirculationAPIClient(),
club: new ClubAPIClient(),
cover_image: new CoverImageAPIClient(),

View File

@ -0,0 +1,26 @@
import HttpClient from "./http-client.js";
export class CataloguingAPIClient extends HttpClient {
constructor() {
super({
baseURL: "/cgi-bin/koha/svc/",
});
}
get catalog_bib() {
return {
create: bib_info =>
this.post({
endpoint: "new_bib/frameworkcode=%s".format( bib_info.frameworkcode ),
body: bib_info.record.toXML(),
headers: {
"Content-Type":
"text/xml",
},
}),
};
}
}
export default CataloguingAPIClient;