gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 32492: Add IDs to the rows of the patron messaging table in OPAC and staff interface 

Sometimes you want to hide notice from the messaging options
becaue the library is not using it. With this patch, we'll
have unique IDs on the <tr> to do so easily.

To test:
* Look at the messaging preferences
  * in the OPAC messaging tab
  * in the staff interface details tab
  * in the staff interface patron edit form
* Verify there are no classes or IDs on the rows or other elements
* Apply patch
* Verify there are nice IDs now on the table rows (tr elements)
  for each message.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 7371ee848f)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
(cherry picked from commit 05163003b2)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Katrin Fischer 2023-02-10 23:28:40 +01:00 committed by Lucas Gass
parent bfd23785ef
commit 0b63fb2a93
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
View File

@ -15,7 +15,7 @@
[% FOREACH messaging_preference IN messaging_preferences %]
[% NEXT IF !Koha.Preference( 'ILLModule' ) && messaging_preference.message_name.match('^Ill_') %]
[% NEXT IF messaging_preference.Auto_Renewals && Koha.Preference('AutoRenewalNotices') != 'preferences' %]
<tr>
<tr id="[% messaging_preference.message_name _ "_message" | lower %]">
<td>[% IF ( messaging_preference.Item_Due ) %]<span>Item due</span>
[% ELSIF ( messaging_preference.Advance_Notice ) %]<span>Advance notice</span>
[% ELSIF ( messaging_preference.Hold_Filled ) %]<span>Hold filled</span>

2
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
View File

@ -61,7 +61,7 @@
[% FOREACH messaging_preference IN messaging_preferences %]
[% NEXT IF !Koha.Preference( 'ILLModule' ) && messaging_preference.message_name.match('^Ill_') %]
[% NEXT IF messaging_preference.Auto_Renewals && Koha.Preference('AutoRenewalNotices') != 'preferences' %]
<tr>
<tr id="[% messaging_preference.message_name _ "_message" | lower %]">
<td>[% IF ( messaging_preference.Item_Due ) %]<span>Item due</span>
[% ELSIF ( messaging_preference.Advance_Notice ) %]<span>Advance notice</span>
[% ELSIF ( messaging_preference.Hold_Filled ) %]<span>Hold filled</span>