gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 24175: Use itemnumber when searching for holds in SIP drop_hold 

To test:
1 - place a hold for a patron
2 - Get SIP running
    https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup
3 - edit the sip_cli_emulator.pl for hold_mode from '+' to '-'
4 - Attempt to cancel hold
5 - It fails
6 - Apply patch
7 - Try again
8 - It succeeds

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Nick Clemens 2019-12-04 18:50:41 +00:00 committed by Martin Renvoize
parent c3a1a6b9ad
commit 09aa99391f
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
C4/SIP/ILS/Transaction/Hold.pm
View File

@ -87,11 +87,10 @@ sub drop_hold {
return $self;
}
my $item = Koha::Items->find({ barcode => $self->{item}->id });
my $holds = Koha::Holds->search(
{
biblionumber => $item->biblionumber,
itemnumber => $self->{item}->id,
itemnumber => $item->itemnumber,
borrowernumber => $patron->borrowernumber
}
);