gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 10595: don't display OpacTopissue page when system preference is turned off 

When the syspref is turned off, the link is hidden but the page is still
accessible. This patch checks the syspref and redirects to 404 if it is disabled.

Test plan:

Before applying the patch

Enable OpacTopissue
  Observe there is a link to opac-topissues.pl next to Advanced search etc.
  Follow that link, observe that opac-topissues.pl is loading
Disable OpacTopissue
  Observe the link is gone
  Manually open /koha/opac-topissues.pl and check that it is loading even though the feature is disabled

Apply patch

(OpacTopissue still diabled)
Manually open /koha/opac-topissues.pl and observe that you are being redirected to the 404 page.
Enable OpacTopissue
  Follow the link or manuall open opac-topissues.pl and check that it is working

Signoff the patch.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 04ca81bc35)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Works as expected
This commit is contained in:
Mirko Tietgen 2013-07-16 21:51:01 +02:00 committed by Tomas Cohen Arazi
parent 1ebaaa8c4b
commit 094bfd0d17
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
opac/opac-topissues.pl
View File

@ -40,6 +40,13 @@ plugin that shows a stats on borrowers
=cut
my $input = new CGI;
# if OpacTopissue is disabled, leave immediately
if ( ! C4::Context->preference('OpacTopissue') ) {
print $input->redirect("/cgi-bin/koha/errors/404.pl");
exit;
}
my $branches = GetBranches();
my $itemtypes = GetItemTypes();