Bug 37861: Fix XSS vulnerability in barcode append function

When user inputs were appended directly to the barcode table, the values were not properly escaped, allowing potential XSS attacks. This patch ensures that user inputs are sanitized and safely added to the DOM using .text() and .attr() methods to prevent script injection.

To test:
Enable the "SelfCheckInModule".
Open the barcode input form.
Enter a barcode with HTML or script tags.
Without the patch, observe that the script is executed.
Apply the patch.
Repeat step 2.
Verify that the input is escaped and no script execution occurs.
Check that the barcode is properly appended to the table.

Documentation:
No updates required.

Sponsored-by: KillerRabbitAos

Signed-off-by: Bo Gustavsson <bosse@gustavsson.one>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: wainuiwitikapark <wainuiwitikapark@catalyst.net.nz>
(cherry picked from commit b576548223)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Artur 2024-09-07 18:12:05 +02:00 committed by Lucas Gass
parent 86e2c8f2a8
commit 081433217c
1 changed files with 44 additions and 29 deletions

View File

@ -218,37 +218,52 @@
});
$(document).ready(function() {
// Barcodes scanning table initially hidden
$("#sci_barcodes_table").hide();
// Control de 'append' button behaviour
$("#sci_append_button").on('click',function( e ){
// Make sure the form is not submitted by the button
e.preventDefault();
var barcode = $('#barcode_input').val();
//var result = validate_barcode( barcode );
$('#sci_barcodes_table tbody').append(
'<tr style="font-size: initial;"><td>' +
barcode +
'<input type="hidden" name="barcode" value="' + barcode + '" />' +
'</td></tr>' );
// Make sure the table is now displayed
$("#sci_barcodes_table").show();
$('#sci_checkin_button').show();
$('#sci_refresh_button').show();
barcodes.push(barcode);
// clean the input, reset the focus
$('#barcode_input').val('');
dofocus();
});
// Barcodes scanning table initially hidden
$("#sci_barcodes_table").hide();
$(".helpModal-trigger").on("click",function(e){
e.preventDefault();
$("#helpModal").modal("show");
});
// Control the 'append' button behaviour
$("#sci_append_button").on('click', function(e) {
// Make sure the form is not submitted by the button
e.preventDefault();
var barcode = $('#barcode_input').val().trim(); // Trim whitespace from input
if (barcode !== "") {
// Properly escape the barcode value by using .text() for display
var barcodeHtml = $('<tr style="font-size: initial;"><td></td></tr>');
barcodeHtml.find('td').text(barcode).append(
$('<input>').attr({
type: 'hidden',
name: 'barcode',
value: barcode
})
);
$('#sci_barcodes_table tbody').append(barcodeHtml);
// Make sure the table is now displayed
$("#sci_barcodes_table").show();
$('#sci_checkin_button').show();
$('#sci_refresh_button').show();
// Add barcode to the array
barcodes.push(barcode);
}
// Clear the input and reset the focus
$('#barcode_input').val('');
dofocus();
});
$(".helpModal-trigger").on("click", function(e) {
e.preventDefault();
$("#helpModal").modal("show");
});
// Set focus at the beginning
dofocus();
});
// set focus at the beginning
dofocus();
});
var idleTime = 0;
$(document).ready(function () {